Extend drift detect server to expose metrics #2557
Conversation
…re server is compatible
|
Mon Oct 19 14:30:09 UTC 2020 impatient try |
|
Mon Oct 19 14:30:18 UTC 2020 impatient try |
|
Mon Oct 19 14:37:20 UTC 2020 impatient try |
|
Mon Oct 19 14:37:32 UTC 2020 impatient try |
| runtime_metrics = seldon_response.metrics | ||
| if runtime_metrics is not None: | ||
| if validate_metrics(runtime_metrics): | ||
| self.seldon_metrics.update(runtime_metrics, "ce_server") |
There was a problem hiding this comment.
is ce_server not a bit generic. What is this argument used for?
There was a problem hiding this comment.
This is an extra tag, more specifically it's the "method" tag, which in the case of the metrics in the python wrapper it would be "predict", "feedback", "input_transform", etc. In this case it would just be the "ce_server" metrics. I guess we could have it more specific to the type of server, such as DRIFT / OUTLIER / CUSTOM_METRICS?
|
Wed Oct 21 13:50:07 UTC 2020 impatient try |
|
Wed Oct 21 13:50:24 UTC 2020 impatient try |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thu Oct 22 13:56:43 UTC 2020 impatient try |
|
Thu Oct 22 13:56:47 UTC 2020 impatient try |
Fixes #2537