WIP: add feedback to batch processor #2653
Conversation
|
Mon Nov 16 18:32:18 UTC 2020 impatient try |
|
Mon Nov 16 18:32:26 UTC 2020 impatient try |
|
Wed Nov 18 15:17:05 UTC 2020 impatient try |
|
Wed Nov 18 15:17:26 UTC 2020 impatient try |
|
Wed Nov 18 15:22:29 UTC 2020 impatient try |
|
Wed Nov 18 15:22:29 UTC 2020 impatient try |
| } | ||
| } | ||
| # Feedback Protos does not support meta and SeldonClient.feedback does not support headers | ||
| # feedback_kwargs["meta"] = meta |
There was a problem hiding this comment.
Remove (or if moved to single function can be left under if statement)
| str_output = None | ||
| for i in range(retries): | ||
| try: | ||
| # TODO: Add functionality for explainer |
There was a problem hiding this comment.
Move todos into issues where possiuble
| str_output = json.dumps(seldon_payload.response) | ||
| break | ||
| except (requests.exceptions.RequestException, AssertionError) as e: | ||
| # print("Exception:", e, "retries:", retries) |
|
Wed Nov 18 15:39:13 UTC 2020 impatient try |
|
Wed Nov 18 15:39:18 UTC 2020 impatient try |
|
Wed Nov 18 15:42:40 UTC 2020 impatient try |
|
Wed Nov 18 15:42:41 UTC 2020 impatient try |
|
/approve |
|
Wed Nov 18 15:50:22 UTC 2020 impatient try |
|
Wed Nov 18 15:50:28 UTC 2020 impatient try |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Extends batch-processor to be able to send feedback messages.
Feedback messages must be provided in the "raw" format.
Works both with gRPC and REST.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: