Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix issue #304
Redis
shipped inseldon-core
helm chart is used for two purposes:seldon-apiserver
.Predictive Unit
if its.s2i/environment
PERSISTENCE
flag is set to 1.Since we can use
ambassador
to replaceseldon-apiserver
(which means we can disableseldon-apiserver
in that case), and we can use a differentRedis
server forPERSISTENCE
flag (if the admin already has aRedis
server running), there is a need to disable theRedis
shipped inseldon-core
helm chart.