fix(agent): cleanup rclone directory on errors #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any error occurring after the downloading of the model artifact but before the model was properly registered in the agent's model repository would result in the rclone path not being cleaned-up. This leads to the PVC filling up and requiring end-user manual intervention. This change fixes this, by cleaning the rclone path even when errors occur.
sakoush
approved these changes
Aug 13, 2024
Modifies the httpmock used for rclone testing to enable it to simulate rclone download failures. Test also checks that the cleanup endpoint was called at least once (if the download succeeds)
|
I did add at least some minimal tests by improving on how we use httpmock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any error occurring after the downloading of the model artifact but
before the model was properly registered in the agent's model repository would
result in the rclone path not being cleaned-up. This leads to the PVC filling up
and requiring end-user manual intervention.
This change fixes this, by cleaning the rclone path even when errors occur.
Which issue(s) this PR fixes: