Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): improve HPA autoscaling docs #5953

Merged
merged 3 commits into from
Oct 4, 2024
Merged

feat(docs): improve HPA autoscaling docs #5953

merged 3 commits into from
Oct 4, 2024

Conversation

lc525
Copy link
Member

@lc525 lc525 commented Oct 3, 2024

  • fix formatting for reading outside gitbook
  • add details on custom metrics of type Object

Special notes for your reviewer:

  • This PR also tests what happens when the docs on gitbook get modified independently (the same HPA autoscaling file has been "merged" on gitbook, but of course gitbook was not able to commit to the v2 branch)

@lc525
feat(docs): improve HPA autoscaling docs
d5e28c0 
- fix formatting for reading outside gitbook
- add details on custom metrics of type `Object`
@lc525 lc525 requested a review from sakoush as a code owner October 3, 2024 19:42
@lc525 lc525 added the v2 label Oct 3, 2024
@lc525 lc525 requested review from Rajakavitha1 and removed request for sakoush October 3, 2024 19:43
Rajakavitha1
Rajakavitha1 approved these changes Oct 4, 2024
View reviewed changes
Copy link

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions. other wise it is a /lgtm from me.

docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
docs-gb/kubernetes/hpa-rps-autoscaling.md Outdated Show resolved Hide resolved
@lc525 @Rajakavitha1
Apply suggestions from code review
e9ec37f 
Consistent style and phrasing

Co-authored-by: Rajakavitha Kodhandapani <[email protected]>
@lc525 lc525 merged commit d62e997 into SeldonIO:v2 Oct 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Rajakavitha1 approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lc525 @Rajakavitha1