Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): changes from v2 for release 1.8.4 (3) #5966

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix(ci): changes from v2 for release 1.8.4 (3) #5966

merged 2 commits into from
Oct 8, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Oct 8, 2024

No description provided.

Rajakavitha1 and others added 2 commits October 8, 2024 13:58
* add grace period before unloading a model from the agent

* add note for grace period

* add test for grace unload env

* use the correct variable for grace period

* adjust envar for grace period

* add helm config for unload grace period

* fix test

* adjust cmd line arg name for grace period
@sakoush sakoush requested a review from lc525 as a code owner October 8, 2024 11:48
@sakoush sakoush removed the request for review from lc525 October 8, 2024 11:49
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sakoush sakoush merged commit 10b6966 into release-2.8 Oct 8, 2024
15 of 16 checks passed
@sakoush sakoush added the v2 label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants