WIP: explainers #690
Merged
WIP: explainers #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandawsonuk
commented
Jul 15, 2019
| @@ -17,12 +17,12 @@ kubectl rollout status -n seldon-system statefulset/seldon-operator-controller-m | |||
|
|
|||
| sleep 5 | |||
|
|
|||
| helm install --name seldon-single-model ../../helm-charts/seldon-single-model/ --set engine.env.LOG_MESSAGES_EXTERNALLY="true" --set model.annotations."seldon\.io/istio-gateway"="kubeflow-gateway.kubeflow.svc.cluster.local" | |||
| helm install --name seldon-single-model --namespace default ../../helm-charts/seldon-single-model/ --set engine.env.LOG_MESSAGES_EXTERNALLY="true" --set model.annotations."seldon\.io/istio-gateway"="kubeflow-gateway.kubeflow.svc.cluster.local" | |||
There was a problem hiding this comment.
Not sure why this is showing as this already seems to be in master - https://github.com/SeldonIO/seldon-core/blob/master/examples/centralised-logging/full-setup-existing-kubeflow.sh#L20
ryandawsonuk
commented
Jul 15, 2019
| GF_SERVER_ROOT_URL: "%(protocol)s://%(domain)s/grafana" |
There was a problem hiding this comment.
ryandawsonuk
force-pushed
the
685-explainers
branch
from
796fa20
to
61eda91
Compare
ryandawsonuk
force-pushed
the
685-explainers
branch
from
43eefac
to
123ae21
Compare
|
There's more to do on this and it will be covered in follow-up PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #685