Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be consistent with message logging annotation names #727

Merged
merged 1 commit into from
Jul 25, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions doc/source/graph/annotations.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,21 @@ Otherwise any annotations starting with `seldon.io/engine-` will be interpreted
* Locations : SeldonDeployment.spec.predictors.annotations
* [Java Opts example](model_engine_java_opts.md)
* Translates to the environment variable JAVA_OPTS
* ```seldon.io/engine-log-requests``` : Whether to log raw requests from engine
* ```seldon.io/engine-seldon-log-requests``` : Whether to log raw requests from engine
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable LOG_REQUESTS
* ```seldon.io/engine-log-responses``` : Whether to log raw responses from engine
* Translates to the environment variable SELDON_LOG_REQUESTS
* ```seldon.io/engine-seldon-log-responses``` : Whether to log raw responses from engine
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable LOG_RESPONSES
* ```seldon.io/engine-log-messages-externally``` : Option to turn on logging of requests via a logging service
* Translates to the environment variable SELDON_LOG_RESPONSES
* ```seldon.io/engine-seldon-log-messages-externally``` : Option to turn on logging of requests via a logging service
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable LOG_MESSAGES_EXTERNALLY
* ```seldon.io/engine-log-message-type``` : Option to override type set on messages when sending to logging service. Used to determine which logger impl
* Translates to the environment variable SELDON_LOG_MESSAGES_EXTERNALLY
* ```seldon.io/engine-seldon-log-message-type``` : Option to override type set on messages when sending to logging service. Used to determine which logger impl
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable LOG_MESSAGE_TYPE
* ```seldon.io/engine-message-logging-service``` : Option to override url to broker that sends to logging service
* Translates to the environment variable SELDON_LOG_MESSAGE_TYPE
* ```seldon.io/engine-seldon-message-logging-service``` : Option to override url to broker that sends to logging service
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable MESSAGE_LOGGING_SERVICE
* Translates to the environment variable SELDON_MESSAGE_LOGGING_SERVICE

More details on logging-related variables can be seen in the [request-logging example](https://github.com/SeldonIO/seldon-core/tree/master/examples/centralised-logging/README.md).

Expand Down