Grpc apife publish #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Initial commit for rclone dynamic config from model details * Allow k8s secrets for rclone config * Updates from design doc review. Update rclone config key to include user supplied remote. Use oneof in protos. * updated notebook * Review comments. Simplify config function. Fix rclone copy with no config * lint * lint from root * Review comments: make storageConfig optional in proto. Small fixes * Change to inline configuration * lint * Add configuration handler and rclone defaults load * lint * Add watch of local config file * lint * Update main to handle signals * add k8s config handling * Add test for watching configmaps. Change NewConfigHandler signature to allow passing in kubernetes.interface * Initial review updates * review comments part 2 * fix lint * gofmt -w pkg * Simplify struct * Lint Simplify struct * Remove error from NewClient * review fixes * fix typo * Review fixes * lint * review comments * remove agent.json as a possible config file and only allow agent.yaml * remove json processing
sakoush
added a commit
that referenced
this pull request
Jan 26, 2024
…ls/golang.org/x/net-0.17.0 build(deps): bump golang.org/x/net from 0.0.0-20220225172249-27dd8689420f to 0.17.0 in /components/tls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4