Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chainer MNIST example #808

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Conversation

dtaniwaki
Copy link
Contributor

I'm going to use Seldon in my project and since we use Chainer as an ML framework, I started it from the train mnist example first. I think this example will be helpful for Chainer users. Could you consider adding this example?

@axsaucedo
Copy link
Contributor

Looks great @dtaniwaki , thank you for the contribution, we'll review. Can you please make sure you add an .nblink file that points to your ipynb file as well?

@axsaucedo axsaucedo self-requested a review August 16, 2019 14:20
@dtaniwaki
Copy link
Contributor Author

@axsaucedo Added and tested it with make html in the doc dir in my local env.

@axsaucedo
Copy link
Contributor

Lgtm!

@axsaucedo axsaucedo merged commit b9d2032 into SeldonIO:master Aug 16, 2019
@axsaucedo
Copy link
Contributor

Awesome, thanks for the contribution!

@dtaniwaki dtaniwaki deleted the chainer-mnist-example branch August 19, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants