ksonnet notebook with Ambassador #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
added a commit
that referenced
this pull request
Dec 2, 2022
* Fix image set when running Triton standalone * Replace raw Docker Make targets with Compose equivalents This is good for consistency as the services will run with the same config and env vars, regardless of whether they're all started together (with 'up') or individually (with 'run'). This also introduces individual 'stop' commands, which previously did not exist for raw Docker interactions. * Fix typos in Compose commands * Rename Make target for consistency with other local services * Add Make targets for 'docker-compose ps ...' for convenience * Fix typos in Make var usage * Fix typo causing wrong images to be used * Refactor Compose commands/options to vars This reduces verbosity and removes duplication. In turn, this makes the Make targets more legible, easier to maintain, and less prone to typos. * Fix typo using non-existent env file in Compose command * Replace 'run' with 'up' for consistent service names & to allow interactions through Compose commands Otherwise, one needs to use the container name and interact with direct Docker. This is sufficient, but unintuitive when using Compose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.