Patches to prevent XSS #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Oct 1, 2019
|
/uncc @jklaise |
|
/cc @cliveseldon |
|
LGTM, @cliveseldon @ryandawsonuk @MarcoGorelli good to go? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adriangonz
force-pushed
the
xss-patches
branch
from
020631f
to
7fd80a0
Compare
This was referenced Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #837 and #892, which were both related to Cross-Site Scripting (XSS) vulnerabilities.
Fix for issue #837
The fix for issue #837 is pretty straightforward. Before, we were explicitly disabling the HTML escaping. It seems enough to just remove that line. The HTML characters are escaped to their corresponding unicode sequence, so it shouldn't impact anything else downstream.
Fix for issue #892
The fix for issue #892 adds a
Filterto the requests'sFilterChaininspring. The only function of this filter is appending the new header to all responses.The
spring-securitypackage also allows to do this automatically, however it also brings a lot of other things to the table (e.g. user authentication, other headers, etc). We could disable each of these extra features, but it seems safer to just add aFilter.