Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wait for grid script #1901

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

baflQA
Copy link
Contributor

@baflQA baflQA commented Jul 25, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Currently, in case of any errors, the script will run forever.
With this change, it is possible to define the timeout after which the script will exit with an error.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@baflQA baflQA marked this pull request as ready for review July 25, 2023 20:53
@diemol diemol merged commit 3b9c2e2 into SeleniumHQ:trunk Jul 27, 2023
3 checks passed
@baflQA baflQA deleted the improveWaitForGrid branch July 27, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants