Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to create/specify Service Account #1919

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

SurelyMario
Copy link
Contributor

@SurelyMario SurelyMario commented Aug 21, 2023

Description

This PR adds the ability to automatically create a service account for selenium-grid deployment. By default, a service account by the name of selenium-serviceaccount will be made. This functionality can be disabled with .serviceAccount.create: false and a pre-existing service account can be specified via .serviceAccount.name.

Both .spec.serviceAccountName and .spec.serviceAccount were added to maintain some backwards compatibility.

Also minor nit-pick, I removed a duplicate key in .ingress.

Motivation and Context

I wanted it for my environment and also #1783 needed it so why not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Inspired by SeleniumHQ#1783

I needed it in my environment so I figured might as well contribute to upstream
@SurelyMario
Copy link
Contributor Author

I'm gonna be honest, I don't know if some sort of generator was used for README.md so I haven't updated it, @diemol some guidance would be appreciated here.

@diemol
Copy link
Member

diemol commented Aug 23, 2023

README.md was manually created.

@diemol
Copy link
Member

diemol commented Aug 23, 2023

I can merge when instructions on how to use this are added to the read me.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SurelyMario!

@diemol diemol merged commit 49831b1 into SeleniumHQ:trunk Aug 23, 2023
@VietND96 VietND96 linked an issue Nov 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Configurable serviceAccount.name
2 participants