feat: Add option to inject sidecars into Node Pods #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marcusalb
force-pushed
the
selenium-grid-helm-chart-sidecar-support
branch
from
ef1b4f5
to
1090743
Compare
|
Can you add instructions to the readme showing how to use this? |
marcusalb
force-pushed
the
selenium-grid-helm-chart-sidecar-support
branch
from
b210f43
to
02571d7
Compare
|
Hi, i was not completely sure where it would fit the best. Does this look good? |
|
Sorry, I had to merge an earlier PR, which caused the conflicts. Can you please solve them and then I can merge? |
marcusalb
force-pushed
the
selenium-grid-helm-chart-sidecar-support
branch
from
02571d7
to
1574fa2
Compare
|
Done, Rebased the branch. |
diemol
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the possibility to add any type of sidecar into the (Firefox-/Chrome-/Edge-)Nodes. By default no sidecar will be used.
Motivation and Context
A specific use case could be to use a proxy between the Selenium Node and the tested Website.
The motivation is to be able to use Deep Links during testing.
Types of changes
Checklist