Skip to content

Commit

Permalink
[dotnet] add Driver Location Exception and update exception conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Jun 7, 2023
1 parent b30ec03 commit d343d2c
Show file tree
Hide file tree
Showing 3 changed files with 103 additions and 6 deletions.
13 changes: 8 additions & 5 deletions dotnet/src/webdriver/DriverFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,18 @@ public static DriverService VerifyDriverServicePath(DriverService service, Drive
if (File.Exists(executablePath)) return service;
try
{
string driverFullPath = SeleniumManager.DriverPath(options);
service.DriverServicePath = Path.GetDirectoryName(driverFullPath);
service.DriverServiceExecutableName = Path.GetFileName(driverFullPath);
return service;
executablePath = SeleniumManager.DriverPath(options);
service.DriverServicePath = Path.GetDirectoryName(executablePath);
service.DriverServiceExecutableName = Path.GetFileName(executablePath);
}
catch (Exception e)
{
throw new WebDriverException($"Unable to locate driver with path: {executablePath}, for more information on how to install drivers see https://www.selenium.dev/documentation/webdriver/getting_started/install_drivers/", e);
throw new NoSuchDriverException($"Unable to obtain {service.DriverServiceExecutableName} using Selenium Manager", e);
}

if (File.Exists(executablePath)) return service;

throw new NoSuchDriverException($"Unable to locate or obtain {service.DriverServiceExecutableName}");
}
}
}
89 changes: 89 additions & 0 deletions dotnet/src/webdriver/NoSuchDriverException.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
// <copyright file="NoSuchDriverException.cs" company="WebDriver Committers">
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// </copyright>

using System;
using System.Runtime.Serialization;

namespace OpenQA.Selenium
{
/// <summary>
/// The exception that is thrown when a driver is not found.
/// </summary>
[Serializable]
public class NoSuchDriverException : NotFoundException
{

/// <summary>
/// Link to the documentation for this error
/// </summary>
private static string supportUrl = baseSupportUrl + "/driver_location";

/// <summary>
/// Initializes a new instance of the <see cref="NoSuchDriverException"/> class.
/// </summary>
public NoSuchDriverException()
: base(GetMessage(""))
{
}

/// <summary>
/// Initializes a new instance of the <see cref="NoSuchDriverException"/> class with
/// a specified error message.
/// </summary>
/// <param name="message">The message that describes the error.</param>
public NoSuchDriverException(string message)
: base(GetMessage(message))
{
}

/// <summary>
/// Initializes a new instance of the <see cref="NoSuchDriverException"/> class with
/// a specified error message and a reference to the inner exception that is the
/// cause of this exception.
/// </summary>
/// <param name="message">The error message that explains the reason for the exception.</param>
/// <param name="innerException">The exception that is the cause of the current exception,
/// or <see langword="null"/> if no inner exception is specified.</param>
public NoSuchDriverException(string message, Exception innerException)
: base(GetMessage(message), innerException)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="NoSuchDriverException"/> class with serialized data.
/// </summary>
/// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
/// object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext"/> that contains contextual
/// information about the source or destination.</param>
protected NoSuchDriverException(SerializationInfo info, StreamingContext context)
: base(info, context)
{
}

/// <summary>
/// Add information about obtaining additional support from documentation to this exception.
/// </summary>
/// <param name="message">The original message for exception</param>
/// <returns>The final message for exception</returns>
protected static string GetMessage(string message)
{
return message + "; " + supportMsg + supportUrl;
}
}
}
7 changes: 6 additions & 1 deletion dotnet/src/webdriver/SeleniumManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,17 @@ static SeleniumManager()
#endif

binaryFullPath = Path.Combine(currentDirectory, binary);

if (!File.Exists(binaryFullPath))
{
throw new WebDriverException($"Unable to locate or obtain Selenium Manager binary at {binaryFullPath}");
}
}

/// <summary>
/// Determines the location of the correct driver.
/// </summary>
/// <param name="driverName">Which driver the service needs.</param>
/// <param name="options">The correct path depends on which options are being used.</param>
/// <returns>
/// The location of the driver.
/// </returns>
Expand Down

0 comments on commit d343d2c

Please sign in to comment.