Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Gradle setup #117

Merged
merged 1 commit into from
May 9, 2022
Merged

fixed Gradle setup #117

merged 1 commit into from
May 9, 2022

Conversation

SaeedZhiany
Copy link
Contributor

  • Loaded Android Gradle Plugin conditionally

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:

if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).

for more info, you can refer to this thread and especially this comment.

  • Removed buildToolsVersion, because it's no longer needed to specify
    newer versions of the Android Gradle Plugin itself chooses the correct version of BuildTools automatically

Loaded Android Gradle Plugin conditionally
removed buildToolsVersion, because it's no longer needed to specify
@Quantum-35
Copy link

Quantum-35 commented Jul 6, 2020

Good catch @SaeedZhiany.
Can you also add this comment to ReadMe before installation?
` - If you are using React Native version 60, you will need to change the platform version in react-native-biometrics.podspec to version 9.0 so that you can successfully run pod install without version errors.

s.platform = :ios should be same as node_modules/react-native/third-party-podspecs/Folly.podspec
`

@SaeedZhiany
Copy link
Contributor Author

@Quantum-35

My change is not related to iOS, why it should be added in this PR?!
The change is only related to android builds and even users don't need to be informed about it because it's not a break-change (it just prevents from downloading unwanted gradle stuffs on building times)

@SaeedZhiany
Copy link
Contributor Author

@NappyPirate, can you please review and merge this?

@SaeedZhiany
Copy link
Contributor Author

@NappyPirate, can you please review and merge this?

@NappyPirate we are still waiting... please review and merge this PR. Thanks

@jayfunk jayfunk changed the base branch from master to release/2.2.0 May 9, 2022 21:32
@jayfunk jayfunk merged commit 28bfb40 into SelfLender:release/2.2.0 May 9, 2022
@SaeedZhiany SaeedZhiany deleted the patch-1 branch May 10, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants