Make LESS 3.x compatible #30

kohlikohl · 2017-10-16T20:45:56Z

Tried to run this with the latest LESS 3.x (3.0.0-alpha.3) release and got following error:

SyntaxError: variable @googleProtocol is undefined in C:\dev\teams-client-sdk\packages\semantic-ui-less\definitions\globals\site.less
on line 25, column 1:
24
25 .loadFonts();
26

Not yet sure why though.

Everything works fine with version 2.7.2.

The text was updated successfully, but these errors were encountered:

davidpanzarella · 2018-03-09T22:50:02Z

Any update on this? Less-Loader has been recently updated to support Less 3.0, so I'd assume any updates here should now be compatible with 3.0 as well.

rayronvictor · 2018-03-12T11:01:32Z

Same problem in less 3.0.1

dongcai · 2018-04-19T03:06:53Z

Have to roll back to less '2.7.3' to make it work.

… issue with Semantic-UI. See Semantic-Org/Semantic-UI-LESS#30

josuevalrob · 2018-05-08T18:39:21Z

Trying to run npm install semantic-ui -s on my angular cli project and got this:

/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/accord/lib/index.js:29
throw new Error(name + " version " + version + " is not currently supported");
^

Error: less version 3.0.4 is not currently supported
at Object.exports.load (/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/accord/lib/index.js:29:13)
at Object. (/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/gulp-less/index.js:9:29)
at Module._compile (internal/modules/cjs/loader.js:678:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
at Module.load (internal/modules/cjs/loader.js:589:32)
at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
at Function.Module._load (internal/modules/cjs/loader.js:520:3)
at Module.require (internal/modules/cjs/loader.js:626:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object. (/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/semantic-ui/tasks/watch.js:17:18)

josuevalrob · 2018-05-08T18:44:47Z

Sorry for the silly question, but, how can I roll back my less version?

atti187 · 2018-05-08T19:38:56Z

npm install [email protected] --save-dev

josuevalrob · 2018-05-09T15:50:03Z

Sorry, other silly question... If i run:
npm install --global [email protected] --save-dev
It shows me:

/Users/josue/.npm-packages/bin/lessc -> /Users/josue/.npm-packages/lib/node_modules/less/bin/lessc

[email protected]
updated 1 package in 2.756s

Now, But If after that, I go inside the Angular project, and try
npm install semantic-ui
I got the same error:

Error: less version 3.0.4 is not currently supported
at Object.exports.load (/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/accord/lib/index.js:29:13)
at Object. (/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/gulp-less/index.js:9:29)
at Module._compile (internal/modules/cjs/loader.js:678:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
at Module.load (internal/modules/cjs/loader.js:589:32)
at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
at Function.Module._load (internal/modules/cjs/loader.js:520:3)
at Module.require (internal/modules/cjs/loader.js:626:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object. (/Users/josue/WebDevelop/angular/ng-book/semantic/node_modules/semantic-ui/tasks/watch.js:17:18)

The only way to make it work is running npm install [email protected] --save-dev and getting this:

[email protected]
added 18 packages from 22 contributors, removed 6 packages, updated 1 package and moved 1 package in 27.923s

And now, I can start a semantic project by npm install semantic-ui

Is there any way to reinstall [email protected] globally?

0paIescent · 2018-05-24T16:22:10Z

Does anyone feel that the four vulnerabilities found by npm audit are any danger?

0paIescent · 2018-05-24T16:31:33Z

@josuevalrob I'm pretty sure that what you'd need to do is just npm uninstall -g less, then reinstall with the correct version npm install -g [email protected].

ingleo78 · 2018-05-25T02:43:55Z

I had the same problem as everyone, the solution I found was to install cjs and accord, then install semantic-ui and this time if it was allowed to install correctly

sciyoshi · 2018-06-07T05:23:00Z

I've opened a PR that fixes these issues: #44

Any theme.config will also need to be updated by adding (multiple) to the line importing theme.less.

Vages · 2018-07-03T09:49:25Z

Great, @sciyoshi!

Just to make it darned clear to anyone:

@import "~semantic-ui-less/theme.less"; -> @import (multiple) "~semantic-ui-less/theme.less";

Vages · 2018-07-03T21:37:27Z

Time to close this now, @kohlikohl?

Serhansolo · 2018-07-06T14:04:27Z

Guys, I am not sure but I am still getting an error my less version is apparently 3.x+ 😄

Error: less version 3.5.2 is not currently supported
at Object.exports.load (/Users/suy20680/Documents/Projects/test-semantic/test-app/node_modules/accord/lib/index.js:29:13)
at Object. (/Users/suy20680/Documents/Projects/test-semantic/test-app/node_modules/gulp-less/index.js:9:29)
at Module._compile (module.js:635:30)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Module.require (module.js:579:17)
at require (internal/module.js:11:18)
at Object. (/Users/suy20680/Documents/Projects/test-semantic/test-app/node_modules/semantic-ui/tasks/watch.js:17:18)

Vages · 2018-07-06T14:07:15Z

Remembered to change the import, @Serhansolo ?

ThanosSiopoudis · 2018-07-09T22:32:15Z

Looks like less 3.5.x has some breaking changes. 3.0.x works after this merge, but not 3.5.x
The problem is that in Less 3.5.x inline '@' expressions are no longer math'd (less/less.js#3265 (comment))

See error output below with Semantic-UI-Less 2.3.3 and less 3.5.3:

@ribbonOffset: ~"calc("-@ribbonMargin~" - "@ribbonTriangleSize~")";
^
Operation on an invalid type
      in /Users/[...]/node_modules/semantic-ui-less/themes/default/elements/label.variables (line 133, column 0)

JonRowe · 2018-07-10T14:26:24Z

2.3.3 is also still broken on less 3.0.4 for me

ThanosSiopoudis · 2018-07-10T14:42:51Z

@JonRowe did you add (multiple) to your @import statement in theme.config? 2.3.3 and 3.0.4 works fine for me

JonRowe · 2018-07-10T14:48:21Z

Ah my bad, totally didn't, yep 3.0.4 works, just 3.5 and 3.6 don't now.

Serhansolo · 2018-07-16T13:10:34Z

@Vages, sorry for the delayed reply. I just solved the isseu by downgrading my less for the project to 2.7.3 😏

haydar-can · 2018-07-20T13:56:40Z

compatibility new less;

filename : label.variables

133.line

//@ribbonOffset: ~~"calc("-@ribbonMargin~~" - "@ribbonTriangleSize~")";
@ribbonOffset: e("calc(-@{ribbonMargin} - @{ribbonTriangleSize})");

143.line
//@ribbonImageOffset: ~~"calc("-@ribbonImageMargin~~" - "@ribbonTriangleSize~")";
@ribbonImageOffset: e("calc(-@{ribbonImageMargin} - @{ribbonTriangleSize})");

150.line
//@ribbonTableOffset: ~~"calc("-@ribbonTableMargin~~" - "@ribbonTriangleSize~")";
@ribbonTableOffset: e("calc(-@{ribbonTableMargin} - @{ribbonTriangleSize})");

filename:segment.variables

91.line
//@attachedWidth: ~~"calc(100% + "-@attachedHorizontalOffset * 2~~")";
@attachedWidth: e(%("calc(100% + %S%S",-@attachedHorizontalOffset * 2,")"));

filename:step.variables

98.line

//@attachedWidth: ~~"calc(100% + "-@attachedHorizontalOffset * 2~~")";
@attachedWidth: e(%("calc(100% + %S%S", -@attachedHorizontalOffset * 2,")"));

filename:menu.variables

433.line

//@attachedWidth: ~~"calc(100% + "-@attachedHorizontalOffset * 2~~")";
@attachedWidth: e(%("calc(100% + ",-@attachedHorizontalOffset * 2,")"));

jlukic · 2018-10-13T21:59:04Z

This will be fixed in patch today with Semantic-Org/Semantic-UI#6512

andrewleyva mentioned this issue Oct 20, 2017

WIP: Upgrade Semantic Ui to use Semantic-UI-Less Tripwire/octagon#130

Merged

Dromin added a commit to OpenWebslides/openwebslides-frontend that referenced this issue Apr 21, 2018

Updated remaining packages, except less, because of a compatibility…

92360bf

… issue with Semantic-UI. See Semantic-Org/Semantic-UI-LESS#30

Dromin mentioned this issue Apr 21, 2018

Updated dependencies OpenWebslides/openwebslides-frontend#48

Merged

RetroCraft added a commit to RetroCraft/volunteeringpeel that referenced this issue May 13, 2018

fix(less): Downgrade LESS because of Semantic-Org/Semantic-UI-LESS#30

2248fa3

sciyoshi mentioned this issue Jun 7, 2018

Fix to work with less 3.x #44

Closed

sciyoshi mentioned this issue Jun 21, 2018

[Dependency] Add compatibility with Less 3.x Semantic-Org/Semantic-UI#6447

Merged

Vages mentioned this issue Jul 3, 2018

Module Build Failed: Missing closing ')' #38

Closed

Vages mentioned this issue Jul 10, 2018

@ribbonOffset: Operation on an invalid type (Less 3.5.x compatibility) #46

Closed

sciyoshi mentioned this issue Jul 31, 2018

[Dependency] Fix compatibility issue with less >= 3.5 due to math changes Semantic-Org/Semantic-UI#6512

Closed

jlukic closed this as completed Oct 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make LESS 3.x compatible #30

Make LESS 3.x compatible #30

kohlikohl commented Oct 16, 2017

davidpanzarella commented Mar 9, 2018

rayronvictor commented Mar 12, 2018

dongcai commented Apr 19, 2018

josuevalrob commented May 8, 2018

josuevalrob commented May 8, 2018

atti187 commented May 8, 2018

josuevalrob commented May 9, 2018

0paIescent commented May 24, 2018

0paIescent commented May 24, 2018

ingleo78 commented May 25, 2018

sciyoshi commented Jun 7, 2018

Vages commented Jul 3, 2018

Vages commented Jul 3, 2018 •

edited

Loading

Serhansolo commented Jul 6, 2018 •

edited

Loading

Vages commented Jul 6, 2018

ThanosSiopoudis commented Jul 9, 2018

JonRowe commented Jul 10, 2018

ThanosSiopoudis commented Jul 10, 2018

JonRowe commented Jul 10, 2018

Serhansolo commented Jul 16, 2018

haydar-can commented Jul 20, 2018 •

edited

Loading

jlukic commented Oct 13, 2018

Make LESS 3.x compatible #30

Make LESS 3.x compatible #30

Comments

kohlikohl commented Oct 16, 2017

davidpanzarella commented Mar 9, 2018

rayronvictor commented Mar 12, 2018

dongcai commented Apr 19, 2018

josuevalrob commented May 8, 2018

josuevalrob commented May 8, 2018

atti187 commented May 8, 2018

josuevalrob commented May 9, 2018

0paIescent commented May 24, 2018

0paIescent commented May 24, 2018

ingleo78 commented May 25, 2018

sciyoshi commented Jun 7, 2018

Vages commented Jul 3, 2018

Vages commented Jul 3, 2018 • edited Loading

Serhansolo commented Jul 6, 2018 • edited Loading

Vages commented Jul 6, 2018

ThanosSiopoudis commented Jul 9, 2018

JonRowe commented Jul 10, 2018

ThanosSiopoudis commented Jul 10, 2018

JonRowe commented Jul 10, 2018

Serhansolo commented Jul 16, 2018

haydar-can commented Jul 20, 2018 • edited Loading

jlukic commented Oct 13, 2018

Vages commented Jul 3, 2018 •

edited

Loading

Serhansolo commented Jul 6, 2018 •

edited

Loading

haydar-can commented Jul 20, 2018 •

edited

Loading