Add Progress Component #121
Conversation
|
@eanplatter where are we at on this guy, look like it needs a push from your local? |
|
@levithomason this is up to date, I am not sure why it says those commits are 9 days old. It has the updated meta and tests. |
| <Progress> | ||
| <div className='new-child' /> | ||
| </Progress> | ||
| ).scryClass('new-child'); |
There was a problem hiding this comment.
Testing that it picks up it's children.
There was a problem hiding this comment.
scry methods return arrays but do not throw if there are 0 results. So, this test has no assertion it will always pass. You can change it to findClass which will throw an error if it finds 0, or more than 1. Or, we've added this assertText which does a simple assertion that text is present (text is still a child):
render(<Progress>child</Progress>)
.assertText('child');
|
|
||
| // it('should create a div with the class of progress', () => { | ||
| // render(<Progress />).firstClass('progress'); | ||
| // }); |
There was a problem hiding this comment.
I was having some trouble understanding the React-utils. This test was failing because it found two progress classes on <Progress />. I'd be interested in pairing on it.
There was a problem hiding this comment.
Me too! I'm still getting adjusted to the test utils and am interested in a pair here.
There was a problem hiding this comment.
Hero me up folks, I'll clear this up for both of you.
| total: this.props.total, | ||
| value: this.props.value, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Moved all props to the this.element.progress method.
There was a problem hiding this comment.
Passing React children to a jQuery plugin are we ;)
|
Please 💣 that |
|
after removing DS_Store 🉑 |
| ); | ||
| }; | ||
|
|
||
| renderStandardBar = () => { |
There was a problem hiding this comment.
I've asked this before but I'm still a little fuzzy as to why we're not prefixing instance methods like this with _ (e.g. _renderStandardBar) to denote they are not apart of the api fingerprint for this component. /cc @levithomason
There was a problem hiding this comment.
Per Methods section of our fork of the Airbnb styleguide:
Do not use underscore prefix for internal methods of a react component.
Keep in mind these are not classes that users instantiate and use their methods as with a traditional library. JSX handle the class instantiation and interaction is done by props mostly.
There was a problem hiding this comment.
More in depth here: airbnb/javascript#490
|
🍃 |
No description provided.