Skip to content

Commit

Permalink
Adds @Normal usage for non default themes #6227
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Mar 18, 2018
1 parent 6b31647 commit 87c62ff
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- **Icons** - Fixes some icons that were incorrectly named. **Thanks hammy2899** [#6181](https://github.com/Semantic-Org/Semantic-UI/pull/6181) [#6180](https://github.com/Semantic-Org/Semantic-UI/pull/6180) [#6176](https://github.com/Semantic-Org/Semantic-UI/pull/6176) [#6175](https://github.com/Semantic-Org/Semantic-UI/pull/6175)
- **Icons** - Increased specifity on `fitted icon` to fix compatibility with other components [#6125](https://github.com/Semantic-Org/Semantic-UI/issues/6125)
- **Visibility** - Fixed bug that could cause `onScreen` to not work properly for elements that are longer than screen.
- **CSS Variables** - Added use of `@normal` for normal font weight for all non-default themes included in repo. #6227

**Docs**
- Fixes CDN links in docs **Thanks @KSH-code**
Expand Down
2 changes: 1 addition & 1 deletion src/themes/basic/elements/button.variables
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/* Button Variables */
@textTransform: none;
@fontWeight: normal;
@fontWeight: @normal;
@textColor: #333333;

@primaryColor: #333333;
Expand Down
4 changes: 2 additions & 2 deletions src/themes/basic/modules/progress.variables
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
@progressWidth: 100%;
@progressTextAlign: center;

@labelFontWeight: normal;
@labelFontWeight: @normal;
@labelTextAlign: left;
@labelHeight: 1.5em;
@labelHeight: 1.5em;
4 changes: 2 additions & 2 deletions src/themes/bookish/elements/header.variables
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
--------------------*/

@headerFont : 'Karma', 'Times New Roman', serif;
@fontWeight: normal;
@fontWeight: @normal;

@iconSize: 1.5em;
@iconOffset: 0.2em;
Expand Down Expand Up @@ -34,4 +34,4 @@
@largeFontSize: 1.33em;
@mediumFontSize: 1.33em;
@smallFontSize: 1em;
@tinyFontSize: 0.9em;
@tinyFontSize: 0.9em;
4 changes: 2 additions & 2 deletions src/themes/bootstrap3/elements/button.variables
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* Button Variables */
@pageFont: Helvetica Neue, Helvetica, Arial, sans-serif;
@textTransform: none;
@fontWeight: normal;
@fontWeight: @normal;
@textColor: rgba(51, 51, 51, 1);

@borderRadius: @4px;
Expand Down Expand Up @@ -60,4 +60,4 @@

@activeBackgroundColor: #E6E6E6;

@disabledOpacity: 0.65;
@disabledOpacity: 0.65;
2 changes: 1 addition & 1 deletion src/themes/chubby/elements/button.variables
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
@pageFont: 'Source Sans Pro', Arial, sans-serif;

@textTransform: none;
@fontWeight: normal;
@fontWeight: @normal;
@textColor: #333333;

@verticalPadding: 1.1em;
Expand Down

0 comments on commit 87c62ff

Please sign in to comment.