Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search, show results not working #2842

Closed
mgrulich opened this issue Aug 13, 2015 · 5 comments
Closed

search, show results not working #2842

mgrulich opened this issue Aug 13, 2015 · 5 comments
Milestone

Comments

@mgrulich
Copy link

"show results" is not working with search, "hide results" works fine.

@jlukic
Copy link
Member

jlukic commented Aug 13, 2015

Caused by

if( !module.is.visible() && module.is.focused() && !module.is.empty() ) {
  // do show
}

I moved this check outside of the method, so it can be invoked when not focused.

@jlukic jlukic added this to the 2.1 milestone Aug 13, 2015
jlukic added a commit that referenced this issue Aug 13, 2015
@jlukic
Copy link
Member

jlukic commented Aug 13, 2015

Ignore that last commit. heh

@jlukic jlukic closed this as completed Aug 13, 2015
@mgrulich
Copy link
Author

Hi @jlukic thanks for the fix, but can you tell me how can I fix my issue (small code example)? I'm not understand how the changes fixes my issue, sorry.

@jlukic
Copy link
Member

jlukic commented Aug 14, 2015

Here. Previously calling show results required other conditions to be met before showing.
http://jsfiddle.net/acufknc2/

@mgrulich
Copy link
Author

Thank you, has not worked in my first test after your commit, but I've now seen, I've tested with the wrong branch, sorry. Is working for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants