Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox default onEnable and onDisable callbacks are incorrectly defined #3148

Closed
sarbona opened this issue Oct 7, 2015 · 2 comments
Closed
Milestone

Comments

@sarbona
Copy link

sarbona commented Oct 7, 2015

After downloading Semantic-UI 2.1.4 I have tried to disable a checkbox using the command:

$("#pageCoreBasicSwiper").checkbox("disable");

It caused a null error because I don't have a onDisable callback and in semantic the empty callbacks are incorrectly defined as:

$.fn.checkbox.settings = {
...
onEnabled : function(){},
onDisabled : function(){},
...
}

Changing them to onEnable and onDisable worked correctly.

@jlukic jlukic added this to the 2.1.7 milestone Nov 7, 2015
@jlukic
Copy link
Member

jlukic commented Nov 7, 2015

Well thats bad 🥚 😫

@jlukic
Copy link
Member

jlukic commented Nov 30, 2015

Fixed in 2.1.7.

I've left in the existing "typo" names onEnable and onDisable they should be consistent with other callbacks and use onEnabled and onDisabled however this would cause backwards compat issues.

The bug will no longer produce however, because the default settings object should now match spellings nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants