Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically track translation progress inside issue #1105

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

remmycat
Copy link
Contributor

@remmycat remmycat commented Nov 6, 2022

This change should get rid of the annoying task of always keeping the translation progress up to date.

The translation-progress.md will no longer be checked in, but the PR pipeline still runs the check-translation-jsons:no-write script to make sure we don't have any issues in the translation files. (The script no longer errors if the existing file doesn't exist / is different)

Instead, a new GitHub Action will update this issue: #1104 , which we can pin and possibly lock

I also tried to create a better overview table 🙂 and used a little React/HTML where the markdown would've gotten silly otherwise (reverted)

See remmycat#1 for an example of the output

@remmycat remmycat force-pushed the automatic-translation-progress branch from aab0a05 to 4a79e50 Compare November 6, 2022 19:56
@remmycat remmycat requested a review from Sendouc November 6, 2022 20:01
@remmycat
Copy link
Contributor Author

remmycat commented Nov 7, 2022

One thing I want to investigate before merging this is if it's really necessary to go for an html table here.

In previous tries I had put the <details> elements directly into the table cells, which turned out to be an awful idea. But there markdown tables were definitely not enough.

Now that it's really just the emoji and text in each cell, I think getting the HTML (and usage of React for rendering) out of this again might be much neater 🤔

@remmycat remmycat force-pushed the automatic-translation-progress branch from 4a79e50 to e3fefac Compare November 7, 2022 07:05
@remmycat
Copy link
Contributor Author

remmycat commented Nov 7, 2022

Done, back to markdown everything, output is much nicer to look at again.

@Sendouc
Copy link
Owner

Sendouc commented Nov 7, 2022

Yup this looks fantastic :)

@remmycat remmycat merged commit 3ae40b7 into rewrite Nov 7, 2022
@remmycat remmycat deleted the automatic-translation-progress branch November 7, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants