-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded remix-auth-oauth2 to latest version (2.3.0) #1861
Conversation
- Refactored OAuth2Strategy constructor fields to the ones mentioned in the official documentation: https://github.com/sergiodxa/remix-auth-oauth2?tab=readme-ov-file#directly - Issue Link: Sendouc#1852
@Sendouc note: I couldn't actually test the auth changes (since I don't develop Discord bots & don't know how to leverage the auth flow in the app). It may be best if you test the changes since you already have everything set up to do so - I've made all the refactoring changes I can in the code to follow the latest convention/syntax from the official documentation without VSCode giving me typing/non-existing argument errors So in theory all you need to do is just test it on your end & see if it works |
b384aaf
to
d445138
Compare
Thanks for testing @Sendouc! I did some issue lookups in the Since v2.1.0, the default authentication strategy was set to /**
* The method to use to authenticate with the Identity Provider, this can be
* either `http_basic_auth` or `request_body`.
* @default "request_body"
*/
authenticateWith?: "http_basic_auth" | "request_body"; So |
Issue Link: #1852
Description of Changes
Upgraded remix-auth-oauth2 to latest version (2.3.0)
===
Note: will require a rebuild & reupload of the bun lock file after merging other Pull Requests that contain dependency changes.