Add compile-time switch for Sequentia RPC definitions #1
Conversation
| { | ||
|
|
||
| static std::vector<RPCArg> CreateTxDoc() | ||
| { |
There was a problem hiding this comment.
I don't get what that is and how that differs from the other ones. Good enough for now I suppose?
There was a problem hiding this comment.
But then make it a branch until it's somewhat cleaner?
There was a problem hiding this comment.
It's a helper function for generating RPC documentation specific to createrawtransaction. I haven't changed it at all from the Elements source (yet).
There was a problem hiding this comment.
Oh, maybe you were asking about the entire module.
I don't get what that is and how that differs from the other ones. Good enough for now I suppose?
It's effectively a way to override static methods by importing namespace methods from a different module.
But then make it a branch until it's somewhat cleaner?
I don't think #ifdefs containing more than a few lines of code would be cleaner, and in this case it'd be a few dozen. And we're going to want to override both createrawtransaction and CreateTxDoc soon.
|
Closing since this will create extra work if we try to upstream to Elements, and the Elements team has already expressed interest in the No Coin feature (ElementsProject/elements#1302),. |
Uses a compile time flag
__SEQUENTIA__for switching between Sequentia and Elements RPC definitions.Note: The definition of sequentia::createrawtransaction hasn't been updated for the No Fee feature yet. This is more a demonstration and proof-of-concept for how we can extend the protocol without interfering with the Elements codepath.