Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to automatic Black formatting #703

Closed
Serene-Arc opened this issue Nov 30, 2022 · 3 comments
Closed

Switch to automatic Black formatting #703

Serene-Arc opened this issue Nov 30, 2022 · 3 comments

Comments

@Serene-Arc
Copy link
Owner

This issue is to notify the stakeholders of this repository (namely the developers contributing) that I intend to switch this repository to automatic formatting with black.

This will standardise the formatting of the project and it can be integrated with tox and CI to do so automatically.

Needless to say, this will introduce a large number of conflicts if there are PRs in progress since there's a high likelihood that many lines of code will change, I'm opening this and pinging people who will likely be impacted, namely @aliparlakci @OMEGARAZER @chapmanjacobd @Soulsuck24.

For anyone else who is currently developing, hopefully you either see this or it won't be trouble. For those that I have pinged or otherwise have a stake in the current codebase remaining static, please leave comments below so we can organise a timeframe for me to introduce this new part of the workflow in a way that won't cause too much disruption for anyone.

@OMEGARAZER
Copy link
Contributor

No issues here. Any specific settings for black you were looking to use? then can prep ahead of the switch.

@Serene-Arc
Copy link
Owner Author

Going to do default black with 120 character line lengths and isort as well with compatible settings.

The black standard seems pretty unobjectionable.

@OMEGARAZER
Copy link
Contributor

That's what I was figuring, just wanted to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants