2.6.1 #708
2.6.1 #708
Conversation
Covers edge case of additional arguments on extension. Also removed duplicate or redundant tests.
Add tests for links that have arguments added to the extension field in retrieved image_dict
Futureproof for link_to depreciation. https://bugs.python.org/issue39950
TEMPORARY FIX. I can't stress enough this is is temporary and will likely stop working at some point. It works for now though.
Initial switch to temporary tokens for Redgifs. Gets a new auth token for every API request.
Adds support for delayforreddit.com non-direct links.
Narrow except to AttributeError
tested post now showing deleted as user causing tests to fail. Updated to working post.
Seems there was some overlap in test names that was contributing to the test errors. Updated hash and test name.
Fix test for deleted user on post
Fix depreciations in MultiredditHelper and CommentForest.
Suspended user in two tests. Updated hashes and yt-dlp version. Removed success check on known failure.
Add check to verify token was received. Update headers sent to content API. Add availability check for videos to resolve last part of #472 where only SD version is available.
Options not available to download, only archive.
Adds support for pipx with console entry point. closes #702
Get rid of the double with.
Lint with [refurb](https://github.com/dosisod/refurb) using `--disable 126 --python-version 3.9`
Lint with [refurb](https://github.com/dosisod/refurb) using `--disable 126 --python-version 3.9` Also update bats to 1.8.2 and bats-assets to 2.1.0. No changes to the tests, all still passing.
Fix Pylance warnings for typing
|
Before a release can be done, all of the tests have to be 100% working. @Soulsuck24 do you have any idea why the RedGifs MacOS tests are failing? I believe that you were the last to change that module, with a lot of changes. |
|
Taking a look through at where they're failing and where they're not it doesn't look like it's anything wrong on BDFR's end. They'll fail one run and then succeed the next with no changes to the running code (passes b30ced9 but not 0a3b3d7 or failing 175513f but succeeding 7b71676 with the only change being the README.md). Are you able to re-run that test in particular to check it? That said, I will look and see if I can figure anything out to make it sturdier but it doesn't look like it's on this side. |
|
@Soulsuck24 they only seem to be failing on MacOS, which isn't my specialty. The other ones work fine, but the RedGifs module errors out with 403 errors |
|
Well, I got a Mac VM set up and I have yet to have a test fail. All passing with no issues. Like I mentioned, it doesn't seem like it's an issue on BDFR's side. Even my own pull of the most recent commits passes fine Soulsuck24@0a3b3d7 while the same commit didn't pass here. |
|
Weird. Alright, I'll figure something out. |
With the number of fixes and changes (There's a non-working module in 2.6.0), it's probably a good idea to get a release out.
It also would leave a good starting point to work toward #703 and any other automatic linting/formatting.