Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore to ignore user #546

Merged
merged 7 commits into from
Nov 24, 2021

Conversation

jrwren
Copy link
Contributor

@jrwren jrwren commented Oct 31, 2021

No description provided.

@jrwren
Copy link
Contributor Author

jrwren commented Oct 31, 2021

for #513

Copy link
Owner

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, few things:

  • The option you added to the documentation is --ignore, not --ignore-user
  • The if statement shouldn't be in the cloner, it should be in the downloader class. The cloner simply inherits from both of them
  • If you could write tests for the relevant sets of integrations (the cloner, downloader, and archiver) that would be great. The BDFR needs to have every change tested

Copy link
Owner

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for fixing the documentation. This test doesn't pass, in fact it doesn't run at all. I more meant integration tests, although it's not bad to have this one as well.

@aliparlakci aliparlakci changed the base branch from master to development November 16, 2021 14:06
@Serene-Arc Serene-Arc merged commit f0aebdf into Serene-Arc:development Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants