Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link_to depreciation coverage #692

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

OMEGARAZER
Copy link
Contributor

Futureproof for link_to depreciation.
https://bugs.python.org/issue39950

@OMEGARAZER OMEGARAZER closed this Nov 5, 2022
@OMEGARAZER OMEGARAZER deleted the hardlink_to branch November 5, 2022 20:35
@Serene-Arc
Copy link
Owner

Why was this closed?

@OMEGARAZER
Copy link
Contributor Author

apparently github hates me the last few days. I have no idea what is going on.

@OMEGARAZER OMEGARAZER restored the hardlink_to branch November 6, 2022 01:26
@OMEGARAZER OMEGARAZER reopened this Nov 6, 2022
Copy link
Owner

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the except line only catch the error that the depreciation would throw

Narrow except to AttributeError
@Serene-Arc Serene-Arc merged commit 25fdd28 into Serene-Arc:development Nov 8, 2022
@OMEGARAZER OMEGARAZER deleted the hardlink_to branch November 9, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants