Pylance typing #705
Merged
Pylance typing #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually if we're going down this route, I'd prefer we use the newer typing method of doing unions, namely |
Fix Pylance warnings for typing
OMEGARAZER
force-pushed
the
development
branch
from
56d5689
to
69fa1f3
Compare
|
Thanks for conforming to my obsessive formatting, I'll merge |
|
@Serene-Arc Just noticed we'll need to update min version to 3.10 with that formatting. It would essentially drop support for debian 11 and any other OS that doesn't ship with it available. |
|
It's been reverted. Much as I would like to switch to 3.10 we should probably wait for Debian at the very least. That puts the upgrade time at mid next year at this rate. For now, we should stick to 3.9 compatible typing. If you could do the PR without my change again, that would be great, you were right the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pylance warnings for typing