Add ability to retest #734
Conversation
Adds ability to re-run tests if required. Ignores if only markdown files are changed as they are handled by tox and weren't touched by these tests. Adds basic Refurb settings to pyproject. Not adding as dev requirement as it's a nice to run but by no means needed. Updates black and isort versions.
|
What do you mean rerun tests? |
|
Also please separate out the refurb stuff to another PR, we can add it to the pre-commit stuff as well, and move towards integrating it into the GH checks. |
Like it says on the tin, lets the tests be re-run in situations like this where the tests are failing outside our control but need to pass before merging. Rather than being forced to make another change and hope the tests pass as they should, a new comment on the PR can be made with
I figured it wasn't worth another PR for 4 lines but if it's going to be integrated more I can move it out. |
OMEGARAZER
force-pushed
the
development
branch
from
8a4745b
to
27e121d
Compare
|
The thing is, I don't like this approach. I want to tests to be fixed rather than having this fix in place and complicating the testing process. If there's no way to fix them, then maybe this can be merged but there should be at least an attempt to fix the failing tests so they do so regularly or pass regularly. |
This doesn't change or alter any tests so I wouldn't call this a fix by any means and it never intended to be.
My point with this though is that in the situation like the one I pointed out there was nothing to fix. Things like all the tests passing in my fork when I publish a change but then a test (seems mac mostly) will fail with 5xx/4xx errors in the PR on completely untouched sections. Was just an attempt to lessen situations where tests are known good but failing outside of BDFR. |
|
You don't have to close it, I just want to double check for reasons why it's failing on MacOS and see if there's any reasons for the failures first. |
***Ability to retest won't be available till on the main branch
Adds ability to re-run tests if required.
Ignores if only markdown files are changed as they are handled by tox and weren't touched by these tests.
Adds basic Refurb settings to pyproject. Not adding as dev requirement as it's a nice to run but by no means needed.