Add ember-modifier dependency

[SergeAstapov]

No description provided.

[chriskrycho]

Great start on this! I had some suggestions, ranging from fixing typos and grammar to adding more text entirely. Let me know once you've incorporated this!

[SergeAstapov]

Great start on this! I had some suggestions, ranging from fixing typos and grammar to adding more text entirely. Let me know once you've incorporated this!

Thank you for suggestions! I've applied them all and made some tweaks adding more prose to Motivation section.

Integrate ember-modifier into the @ember/modifier package directly.

BTW this alternate option seem logical to me.
I wonder if there are strong arguments why we should not be doing exact same thing?

[chriskrycho]

BTW this alternate option seem logical to me. I wonder if there are strong arguments why we should not be doing exact same thing?

We might! I’ll chat about it with folks at the Framework team meeting this week. We also might do it via @glimmer/modifier. We just need to align on the best thing design-wise!

[chriskrycho]

Really nice expansion! One more suggested round of tweaks, and then you should open it against the Ember RFCs repo. Thanks for your work on this!

[SergeAstapov]

@chriskrycho thank you for the great suggestions! They have been applied and PR opened emberjs#811