Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracked-built-ins dependency #2

Closed
wants to merge 2 commits into from
Closed

Add tracked-built-ins dependency #2

wants to merge 2 commits into from

Conversation

SergeAstapov
Copy link
Owner

@chriskrycho this is another RFC we discussed in tracked-tools/tracked-built-ins#274

Would love some feedback as I'm not totally sure I understand motivation same way as core team

@chriskrycho
Copy link

Thank you! I’ll review it tomorrow morning! The short version is: Ember had historically shipped EmberArray and EmberObject as well as Map and Set implementations to make it easy to work with those types in a reactive way. tracked-built-ins does the same for the auto-tracking era.

(Feel free to steal from that for the summary and/or motivation as you like!)

chriskrycho
chriskrycho suggested changes Mar 29, 2022
View reviewed changes
Copy link

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! One round of revisions suggested; feel free to open the RFC once you've made these tweaks. Thank you for doing this!

@SergeAstapov
Copy link
Owner Author

@chriskrycho thank you for the great suggestions! All of them have been applied and PR opened emberjs#812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeAstapov @chriskrycho