New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newFee can equals maxStreamingFeePercentage in StreamingFeeModule #224

Open

gzliudan wants to merge 1 commit into SetProtocol:master from gzliudan:StreamingFeeModule

Contributor

gzliudan commented Mar 17, 2022

In StreamingFeeModule, streamingFeePercentage can be equal to maxStreamingFeePercentage when initialize:

require(_settings.streamingFeePercentage <= _settings.maxStreamingFeePercentage, "Fee must be <= max.");

But when updateStreamingFee _newFee can't be equal to _maxStreamingFeePercentage:

require(_newFee < _maxStreamingFeePercentage(_setToken), "Fee must be less than max");

It seems that use <= to check is better.


          newFee can equals maxStreamingFeePercentage in StreamingFeeModule

dbd3834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet