ArrakisUniswapV3AmmAdapter #260
Conversation
contracts/protocol/integration/amm/ArrakisUniswapV3AmmAdapter.sol
Outdated
Show resolved
Hide resolved
| address public immutable router; | ||
|
|
||
| // UniswapV3 factory contract | ||
| IUniswapV3Factory public immutable uniV3Factory; |
There was a problem hiding this comment.
To remove unused variable
| "_minLiquidity is too high for input token limit" | ||
| ); | ||
|
|
||
| target = router; |
There was a problem hiding this comment.
Why are we using (i.e. encoding for) the addLiquidity method on the arrakis router instead of using the mint method on the vault directly. I'd expect the latter to incurr lower gas fees right ?
| // Attempt to get the tokens of the provided pool | ||
| address token0; | ||
| address token1; | ||
| try IArrakisVaultV1(_pool).token0() returns (IERC20 _token0) { |
There was a problem hiding this comment.
Try catch statements like these don't catch the case when _pool is not a smart contract, in which case the whole tx will still fail. If you want to avoid that you might want to add a codesize check for the _pool address.
See this so question that I posted regarding this topic:
https://ethereum.stackexchange.com/questions/128845/why-does-soliditys-try-catch-not-catch-call-to-non-contract-address-revertion
|
|
||
| // Internal function string for adding liquidity | ||
| string internal constant ADD_LIQUIDITY = | ||
| "addLiquidity(address,uint256,uint256,uint256,uint256,address)"; |
There was a problem hiding this comment.
Just checking, we don't include addLiquidityEth interface in this adapter since we only allow providing liquidity with ERC20 and not native ETH correct ?
| override | ||
| returns (address /*target*/, uint256 /*value*/, bytes memory /*data*/) | ||
| { | ||
| revert("Arrakis single asset addition is not supported"); |
There was a problem hiding this comment.
Couldn't this be implemented using the rebalanceAndAddLiquidity method on the router ? Any specific reason why we didn't implement this ?
The changes implement an adapter for the AmmModule which supports Arrakis Vaults holding UniswapV3 positions.
The goal is to be able to create and hold Uniswap's V3 Liquidity Provision tokens (LP tokens) inside of a Set Token.
There is a challenge caused by UniV3's LP tokens being ERC721s (NFTs). And since
AmmModule.solassumes amm pool tokens to follow IERC20, UniswapV3 Pools aren't directly integrable.So are using Arrakis (Arrakis V1 Doc) that creates and holds Uniswap V3 Liquidity Position and issues fungible ERC20 tokens to anyone who adds more liquidity.
There are three main contracts being used in the implementation:
Other Relevant Contracts - Link
Using Arrakis Factory, anyone can create new Arrakis Vaults (analogous to Token Pools) which hold UniswapV3 liquidity position for a pair of ERC20 tokens for a given price range bound (assuming there already exists a pool for the same pair of tokens in UniswapV3).
Once Vault is created, it works similar to UniswapV2 liquidity pools and can be passed to
AmmModulecontract as ammPool, which then will callArrakisUniswapV3Adapterreturning calldata with Arrakis Router, which handles adding and removing liquidity and minting/burning ERC20 Tokens to the caller (in our case it is SetToken).The
routerin theArrakisUniswapV3Adapter.solis the address to the Arrakis Router contract which is passed in the constructor along with UniswapV3 Factory address. The overall approach is now very similar to howUniswapV2AmmAdapteris implemented with the following correlations: