Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Symfony 6 and drop Symfony 4 and PHP < 8.1 #88

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Support Symfony 6 and drop Symfony 4 and PHP < 8.1 #88

merged 10 commits into from
Jan 30, 2024

Conversation

lruozzi9
Copy link
Contributor

This needs before #87

@loevgaard
Copy link
Member

Let's remove support for SF4

@lruozzi9 lruozzi9 force-pushed the support-symfony-6 branch 2 times, most recently from 8ef9203 to ab7875f Compare May 22, 2023 08:12
@lruozzi9
Copy link
Contributor Author

@loevgaard it should be added a tag on https://github.com/Setono/DoctrineORMBatcherBundle to support Sf 6, the code on the main branch looks like supports it already.

@lruozzi9 lruozzi9 force-pushed the support-symfony-6 branch 11 times, most recently from ed17005 to 9a05ccb Compare July 12, 2023 13:15
@lruozzi9 lruozzi9 changed the title Support Symfony 6 Support Symfony 6 and drop Symfony 4 and PHP 7.4 Jul 12, 2023
@lruozzi9 lruozzi9 marked this pull request as ready for review July 12, 2023 13:22
@lruozzi9
Copy link
Contributor Author

@loevgaard here we are!

@loevgaard
Copy link
Member

Crazy!

loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
src/EventListener/Filter/AbstractFilterListener.php
@@ -42,7 +42,7 @@ protected function getAlias(QueryBuilder $queryBuilder): string
throw new InvalidArgumentException('This filter only works with one root alias');
}

return $aliases[0];
return reset($aliases);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this faster or why did you change this? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of a Psalm error.. The index "0" could not exist..

loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
psalm.xml Outdated Show resolved Hide resolved
loevgaard
loevgaard reviewed Jul 12, 2023
View reviewed changes
composer-unused.php Outdated Show resolved Hide resolved
@lruozzi9 lruozzi9 force-pushed the support-symfony-6 branch 3 times, most recently from 1ab30e7 to 4725765 Compare July 13, 2023 08:36
@lruozzi9 lruozzi9 changed the title Support Symfony 6 and drop Symfony 4 and PHP 7.4 Support Symfony 6 and drop Symfony 4 and PHP < 8.1 Jul 13, 2023
@lruozzi9 lruozzi9 requested a review from loevgaard July 13, 2023 08:55
@loevgaard
Copy link
Member

This is great work, @lruozzi9. Did you test it in your application?

@lruozzi9
Copy link
Contributor Author

lruozzi9 commented Aug 3, 2023

Yes, it is already in production!

@kenny-inventis
Copy link

Hey FYI, I noticed that the support branch composer.json allows for: "symfony/http-foundation": "^5.4.7 || ^6.0". However, in the ProcessFeedAction an assert has been added on line 45 for "Symfony\Component\HttpFoundation\Session\FlashBagAwareSessionInterface"
Which has just been introduced in 6.2: https://github.com/symfony/http-foundation/tree/6.2/Session
So this will break if your project pulls a http-foundation version lower than 6.2.

@lruozzi9
Copy link
Contributor Author

Hi, @kenny-inventis! Thank you so much for your feedback. I updated the required Symfony version to 6.3 as 6.2 or lower are already not maintained.

@lruozzi9
Copy link
Contributor Author

@loevgaard can you consider releasing a tag with these changes? We are currently using that in two production websites 😅

@loevgaard
Copy link
Member

@lruozzi9: Argh, didn't notice before now. I have clients still running PHP 7.4 and you changed the PHP requirement. Could you revert to >=7.4?

@diimpp
Copy link

diimpp commented Oct 31, 2023

@lruozzi9: Argh, didn't notice before now. I have clients still running PHP 7.4 and you changed the PHP requirement. Could you revert to >=7.4?

Shouldn't they just stay with older plugin version? Sylius requires ^8.0 since 1.11

@delyriand
Copy link

Hi @lruozzi9!

To make the module Sf6 compatible, you'll need to modify the route definition in the src/Resources/config/routing/admin.yaml file.

Since version 4.1, the "app.my_controller:myAction" syntax has been deprecated, cf symfony/symfony#26085

@delyriand delyriand mentioned this pull request Jan 29, 2024
Open
@loevgaard loevgaard merged commit 078f73a into Setono:master Jan 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loevgaard loevgaard Awaiting requested review from loevgaard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lruozzi9 @loevgaard @kenny-inventis @diimpp @delyriand