Adding Pipeline methods [WIP] #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Het-Shah
reviewed
Jun 10, 2021
| methods. | ||
|
|
||
| :param: steps (list) list of KD_Lib.KD or KD_Lib.Pruning or KD_Lib.Quantization | ||
| :param: epochs (int) number of iterations through whole batch for each method in |
There was a problem hiding this comment.
We can remove this parameter right? Since each individual method will have epochs in its initialization
There was a problem hiding this comment.
Distillation specifies these parameters in train_student method instead of class constructor.
Het-Shah
reviewed
Jun 10, 2021
KD_Lib/utils/pipeline.py
Outdated
Comment on lines
74
to
81
| if hasattr(process, 'train_student'): | ||
| process.train_student(self.epochs, self.plot_losses, self.save_model, self.save_model_path) | ||
| elif hasattr(proces, 'prune'): | ||
| process.prune() | ||
| elif hasattr(process, 'quantize'): | ||
| process.quantize() | ||
| else: | ||
| raise TypeError("{} is not supported by the pipeline yet." |
There was a problem hiding this comment.
Save the final model after all the steps in the process
khizirsiddiqui
force-pushed
the
add-pipeline
branch
from
ccddfb9
to
a999eed
Compare
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 55.83% 0.79% -55.05%
==========================================
Files 60 61 +1
Lines 2115 2012 -103
==========================================
- Hits 1181 16 -1165
- Misses 934 1996 +1062
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.