Skip to content

Commit

Permalink
Update a wide variety of comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sha0den committed Sep 30, 2024
1 parent fc428d6 commit 74b3bb5
Show file tree
Hide file tree
Showing 33 changed files with 325 additions and 224 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,13 @@


## Code Optimization
- **September 15, 2024:** 1 File Changed
- **September 30, 2024:** 32 Files Changed
- Add/edit a lot of function comments and move a couple of functions (within the same file)
- Change several magic numbers to the correct constants and add constants for wLineSeparation

<br/>

- **[September 15, 2024](https://github.com/Sha0den/poketcg_v2/commit/fc428d659332548d2c5f5a856518db642db3e29b):** 1 File Changed
- Some more comments and minor optimizations in home/substatus.asm

<br/>
Expand Down
4 changes: 4 additions & 0 deletions src/constants/text_constants.asm
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,7 @@ DEF TX_CTRL_END EQU $10
; wFontWidth constants
DEF FULL_WIDTH EQU $0
DEF HALF_WIDTH EQU $1 ; non-0

; wLineSeparation constants
DEF DOUBLE_SPACED EQU 0
DEF SINGLE_SPACED EQU 1 ; non-0
2 changes: 1 addition & 1 deletion src/engine/bank20.asm
Original file line number Diff line number Diff line change
Expand Up @@ -1360,7 +1360,7 @@ SpriteNullAnimationFrame:
;Func_80c64:
; ld a, [wLineSeparation]
; push af
; ld a, $01 ; no line separator
; ld a, SINGLE_SPACED
; ld [wLineSeparation], a
; ; load opponent's name
; ld a, [wOpponentName]
Expand Down
2 changes: 1 addition & 1 deletion src/engine/challenge_machine.asm
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ChallengeMachine_Reset:
; if a challenge is already in progress, then resume the challenge.
; otherwise, start a new challenge with 5 rounds.
ChallengeMachine_Start::
xor a ; text is double-spaced
xor a ; DOUBLE_SPACED
ld [wLineSeparation], a
call LoadConsolePaletteData
call ChallengeMachine_Initialize
Expand Down
2 changes: 1 addition & 1 deletion src/engine/copy_card_name.asm
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
; preserves bc and de
; input:
; a = length in number of tiles (the resulting string will be padded with spaces to match it)
; wLoadedCard1 = contains a card_data_struct
; [wLoadedCard1] = all of the card's data (card_data_struct)
_CopyCardNameAndLevel::
push bc
push de
Expand Down
Loading

0 comments on commit 74b3bb5

Please sign in to comment.