Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #684

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Update README.md #684

merged 2 commits into from
Aug 15, 2023

Conversation

jjfreund
Copy link
Contributor

No description provided.

Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the belated review, but this LGTM!

Copy link
Contributor

@schroerbrian schroerbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why we chose to do this. Do we not want to support macOS based development anymore?

@richardxia
Copy link
Member

I can't remember why we chose to do this. Do we not want to support macOS based development anymore?

I think it's because it's out of date and we haven't really put the effort into keeping it up to date. We could probably keep if around if someone wanted to actually go through the steps and make sure they're up to date and match the equivalent steps of the Docker-based setup.

@lgarofalo lgarofalo merged commit 3727ade into master Aug 15, 2023
4 checks passed
@lgarofalo lgarofalo deleted the readme-cleanup branch August 15, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants