Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance texting api #719

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Enhance texting api #719

merged 5 commits into from
Aug 10, 2023

Conversation

schroerbrian
Copy link
Contributor

@schroerbrian schroerbrian commented Jul 19, 2023

This PR addresses two issues:

  1. It adds support to texting information about resources, which was not previously supported by this API. Resources are listed within our search results and receiving their information may be of interest to our user base; this PR enables this
  2. Our texting API was not updated to reflect our support for services that have addresses, which are not inherited from their parent resource's primary address. I've added code that first checks if the selected service has an address and, if not, it falls back to the resource address

There is a corresponding front-end PR here; however, this PR should be able to be merged without breaking the current setup

Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside one minor comment about getting the texting parameters from the already processed data rather than directly from the HTTP parameters!

app/controllers/textings_controller.rb Outdated Show resolved Hide resolved
@schroerbrian schroerbrian merged commit e3031bb into master Aug 10, 2023
4 checks passed
@schroerbrian schroerbrian deleted the enhance-texting-api branch August 10, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants