Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eligibilities hierarchical #740

Merged
merged 3 commits into from
May 1, 2024
Merged

Make eligibilities hierarchical #740

merged 3 commits into from
May 1, 2024

Conversation

jjfreund
Copy link
Contributor

@jjfreund jjfreund commented May 1, 2024

No description provided.

schroerbrian
schroerbrian approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@schroerbrian schroerbrian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the failed test, LGTM!

Looks like the failed test may have just been our CI being flakey. Anyhow, LGTM!

@schroerbrian schroerbrian merged commit 8c5697b into master May 1, 2024
4 checks passed
@schroerbrian schroerbrian deleted the make-eligibilities-hierarchical branch May 1, 2024 18:16
@richardxia richardxia linked an issue Jun 22, 2024 that may be closed by this pull request
Create Hierarchical Eligibilities #737
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroerbrian schroerbrian schroerbrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Hierarchical Eligibilities
2 participants
@jjfreund @schroerbrian