Fix boosted category facet in Resource model. #750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a boosted category column on the services table, with the intent of syncing it to Algolia so that we can perform special types of search ranking based on it on the frontend. However, the way we added it resulted in an obscure bug where the feature appeared to work until someone visits the edit page and saves an edit to a resource or service.
The issue is that when we set the
attributesForFaceting
property, we only added theboosted_category
field to the Service model, not the Resource model. Since we're doing something unusual by sharing the same index for both the Service and Resource model, what actually happens is that the Resource model would sometimes override theattributesForFaceting
in the Algolia index with its own list, causing that attribute to not be usable in filtering anymore.This fixes the issue by adding the
boosted_category
field to Resource's list of facets. To prevent this kind of issue from happening in the future, we refactor the list of attributes for faceting into a single constant that both the Service and Resource models share.