add ListDag function declaration in store #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiningRush
reviewed
Jun 24, 2024
| @@ -119,6 +119,7 @@ type Store interface { | |||
| GetTaskIns(taskIns string) (*entity.TaskInstance, error) | |||
| GetDag(dagId string) (*entity.Dag, error) | |||
| GetDagInstance(dagInsId string) (*entity.DagInstance, error) | |||
| ListDag(input *ListDagInput) ([]*entity.Dag, error) | |||
There was a problem hiding this comment.
也得在 MockStore 实现这个接口，不然之前的用例会失败
There was a problem hiding this comment.
请问你说的之前的用例会失败是什么意思？因为我现在这么用的目前没发现，并且我这样可以正常获取到定义的dag。
store := mod.GetStore()
if store == nil {
return nil
}
dagDefine, err := store.ListDag(nil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我在使用获取全部定义的dag时，发现源码中已经有相关函数实现，但是没有在Store中进行声明，因此不能使用。这个修改是在Store中添加函数声明