DS-2230/rename #141
Merged
DS-2230/rename #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsganden
commented
Jul 28, 2020
| - [ ] Pull request includes a description of the change and the reason behind it. | ||
| - [ ] Pull request [uses keywords](https://help.github.com/en/articles/closing-issues-using-keywords) to close relevant [issues](https://github.com/ShopRunner/creevey/issues). | ||
| - [ ] Pull request includes unit tests for any bug fixes and new functionality. | ||
| - [ ] `./.ci/test.sh` passes locally. |
There was a problem hiding this comment.
IMO you shouldn't have to certify that you've run checks locally; that's what CI/CD is for.
parsing-science
approved these changes
Jul 28, 2020
requirements-dev.in
Outdated
| @@ -4,8 +4,12 @@ black | |||
| flake8 | |||
| flake8-docstrings | |||
| flake8-import-order | |||
| isort | |||
| git+https://github.com/crossnox/m2r@dev#egg=m2r | |||
There was a problem hiding this comment.
Why did we have to switch to using a library from github?
There was a problem hiding this comment.
There was a problem hiding this comment.
I added a comment to requirements-dev.in
Sourcery Code Quality Report (beta)✅ Merging this PR will increase code quality in the affected files by 0.07 out of 10.
Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Process
Contributors from outside ShopRunner should feel free to submit a PR without having completed all of the items below. See CONTRIBUTING.md for additional information.
You can run
./.ci/test.shlocally to check for style issues, run tests, rebuild docs, etc. before submitting changes.Description
Changing the name of the repo in light of J.K. Rowling's comments on transgender issues. Moving from Jenkins to GitHub Actions at the same time to avoid having to make two sets of CI/CD changes.
Checklist
General
sphinx-build docs docs/_htmlrebuilds the docs. Opendocs/_html/index.htmlto check them.)ShopRunner Contributors
The maintainer will complete the following steps for contributions from outside ShopRunner.
CHANGELOG.mdhas been updated._version.pyhas been updated.docs/conf.py.