Make queue setup idempotent #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBr
force-pushed
the
cbruckmayer/fix-retries
branch
from
3f1c3f8
to
ab82d66
Compare
zarifmahfuz
reviewed
Sep 12, 2024
ChrisBr
force-pushed
the
cbruckmayer/fix-retries
branch
from
ab82d66
to
53850e7
Compare
zarifmahfuz
approved these changes
Sep 12, 2024
ChrisBr
commented
Sep 13, 2024
ChrisBr
force-pushed
the
cbruckmayer/fix-retries
branch
from
53850e7
to
b7c10b8
Compare
casperisfine
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced some builds which pushed several times to the queue because of the Redis reconnect configuration. This is problematic for the initial setup command because it's not idempotent and we end up with the same tests multiple times in the queue.
This PR ensures we only push to the queue if it hasn't been initialised yet. It also bumps the timeout so this will happen less frequently.