Switch to clamp for (most) responsive font sizes #1787
Draft
+18
−126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR converts some (most) of Dawn's breakpoint-based font sizes to use
clamp()
instead. This provides a more natural set of font sizes for devices using a middle viewport.The PR takes the font sizes currently used for large and small breakpoints, and uses those values as the
min
andmax
inputs forclamp()
instead. The "preferred" middle values are generalized just to show the effect. We'd need to fine-tune them if we actually wanted to implement this.Before
Note that there's an abrupt change in font sizes around
750px
.13-19-huvwo-0gy4m.mp4
After
Note that the abrupt change is gone, and font sizes transition fluidly from the large font size down to the smaller one.
13-20-8zctp-wqlho.mp4
Testing steps/scenarios
try/responsive-type-sizes
branch in the theme library.