-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cards and Buttons] 3D "Lift" effect on hover #2452
Merged
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
8bdf9ea
Initial commit.
kjellr e260eda
Remove (probably) unnecessary will -change.
kjellr 32ed656
Rename form field label.
kjellr 3f7fae6
Add comments, refine values.
kjellr 8ee2731
Void the effect if reduce motion is active.
kjellr 43edce0
Remove unnecessary params for animation.
kjellr bcafdf5
Create smoother shine animation on mouse out.
kjellr 05ffb33
Update mix-blend-mode for shine.
kjellr 9cd626f
Smooth out the mouse-out animation for cards.
kjellr 03264d6
Merge branch 'main' into animation-3d-lift
kjellr 49ffb3a
Remove unnecessary rule.
kjellr fb3100d
Merge branch 'animation-3d-lift' of https://github.com/Shopify/dawn i…
kjellr 1328bf7
Use (hover: hover) media query
kjellr 34f0517
Simplify selectors, add z-index update.
kjellr 641f6c9
Make cards clickable.
kjellr 49b0715
FIx shine animation.
kjellr 58ec8a9
Prevent clicks with pointer-events: none.
kjellr 849d8c4
Ensure gradient edges don't show.
kjellr 2943f1a
Remove redundant specificity.
kjellr f712457
Start the shine slightly sooner.
kjellr 00a318c
Merge branch 'main' into animation-3d-lift
kjellr ca5a433
Extend animations to cards with shapes.
kjellr 1cd8265
Fix transform animation speed.
kjellr 8760470
Merge branch 'main' into animation-3d-lift
kjellr f4a81ed
Remove browser prefix.
kjellr f47806f
Use duration variables.
kjellr ee00203
Change duration extended value.
kjellr 1ce83e7
Use duration variable again.
kjellr 2e53989
Less intense rotation for collage items.
kjellr 094dbac
Remove animation from videos posters.
kjellr 8d3a282
Tidy up the animation on the video play button.
kjellr 4cacd38
Fine-tune the video play button animation.
kjellr 0ecbe07
Remove unnecessary rotation transforms.
kjellr 5605ce6
Merge branch 'main' into animation-3d-lift
kjellr 5319a01
Add sparkles.
kjellr fea67c1
Update 14 translation files
translation-platform[bot] bb97c0f
Update locales/en.default.schema.json
kjellr d84c0fb
Merge branch 'animation-3d-lift' of https://github.com/Shopify/dawn i…
kjellr b5c900a
Don't apply to link-text.
kjellr d0407ca
Remove the animation from buttons that don't need it.
kjellr eb1215b
Only target enabled buttons.
kjellr e60a0c4
Cover special cases where we don't want the button to appear.
kjellr 702e15d
Tidy up sparkles.
kjellr 6ac38ca
Update 5 translation files
translation-platform[bot] e193a3f
Update 1 translation file
translation-platform[bot] 4875a60
Don't target buttons that are links.
kjellr 034beba
Merge branch 'main' into animation-3d-lift
kjellr 4915de7
Adjust sparkle tactic.
kjellr 23e8c1f
Update behavior when shadows are present.
kjellr 386c6ef
Merge branch 'main' into animation-3d-lift
kjellr efadcac
Fix appearance for card shapes hovers..
kjellr c05a815
Fix more button special cases.
kjellr f119857
Simplify button selectors.
kjellr 4e2c463
Remove broken dynamic payment button styles.
kjellr c6d7c12
Get the right selectors in place.
kjellr b145b5b
Update 12 translation files
translation-platform[bot] 517fc1d
Merge branch 'main' into animation-3d-lift
kjellr 80b0fda
Update 7 translation files
translation-platform[bot] 27220aa
Update 1 translation file
translation-platform[bot] 213d923
Merge branch 'main' into animation-3d-lift
kjellr 9ce7141
Merge branch 'main' into animation-3d-lift
ludoboludo 8055eb1
Merge branch 'main' into animation-3d-lift
ludoboludo 80619c7
Don't apply to tertiary buttons.
kjellr 168f94d
Merge branch 'main' into animation-3d-lift
kjellr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't want to use the easter egg CSS variable you could also just add new CSS rules and the merchant can unlock them by editing the setting value with the text editor. This won't take them off the upgrade path. As far as I know we don't validate the setting values, so you could set it to something like
sparkle
in the text editor even if that's not an option in the online store editor.Screen.Recording.2023-04-10.at.11.42.09.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! I think that could be a fun way to do it. My main hesitation is that the sparkles are currently in addition to the rest of the 3d lift rules — I'd need to add a lot of duplicate rules in to target both
.animate--hover-3d-lift
and.animate--sparkle
. The selectors are already getting a little heavy, so I'm hesitant to duplicate them all.