Remove unused image-banner section setting translation #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfonic
commented
Apr 1, 2023
| @@ -1047,7 +1047,7 @@ | |||
| "margin_top": { | |||
| "label": "Top margin" | |||
| }, | |||
| "header__9": { | |||
| "header__9": { | |||
There was a problem hiding this comment.
It would be great if this PR got merged in so that we don't have this kinds of changes anymore: Add prettier config to support format-on-save #2323
vfonic
commented
Apr 1, 2023
| @@ -37,7 +37,6 @@ | |||
| "settings": { | |||
| "image_overlay_opacity": 40, | |||
| "image_height": "large", | |||
| "adapt_height_first_image": false, | |||
There was a problem hiding this comment.
This is the line that made me go down the rabbit hole.
|
Please have a look @kmeleta @LucasLacerdaUX |
kmeleta
approved these changes
Apr 3, 2023
LucasLacerdaUX
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Looks good to me. I'll try to check why translation platform never removed this key 👀
Thanks for the contribution, @vfonic! :D
|
Looks like it's just because we never removed the english translation string so nothing was triggered on the translation platform side of things. |
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
I removed "adapt_height_first_image" setting translations from image-banner section as it is not used anymore.
It remained here after this PR and seems like it never got removed by the translation platform:
https://github.com/Shopify/dawn/pull/2148/files#r1043139341
Why are these changes introduced?
I was manually upgrading theme from 8.0.1 to 9.0.0. This is always a painful experience. I noticed that there's this new setting value that appeared in my
templates/index.jsonand I removed it since it's not used and it took my time to figure out where this setting came from. Having this setting completely removed, it might save time for other developers in the future how are also manually upgrading their themes.What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist