Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image behavior] Fixed background position #2523

Merged
merged 4 commits into from
May 1, 2023
Merged

[Image behavior] Fixed background position #2523

merged 4 commits into from
May 1, 2023

Conversation

LucasLacerdaUX
Copy link
Contributor

@LucasLacerdaUX LucasLacerdaUX commented Apr 13, 2023 •
edited
Loading

Base PR to add Fixed background position option for Image behavior on sections.

What approach did you take?

  • We're using clip-path alongside position: fixed to recreate a background-attachment: fixed for img elements.

Decision log

# Decision Alternatives Rationale Downsides
1

@LucasLacerdaUX LucasLacerdaUX mentioned this pull request Apr 13, 2023
Merged
13 tasks
@LucasLacerdaUX LucasLacerdaUX changed the title Fixed Position Background [Image behavior] Fixed background position Apr 13, 2023
@ludoboludo ludoboludo self-requested a review April 17, 2023 19:23
ludoboludo
ludoboludo approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but we will see as we test the approach for different sections.

@LucasLacerdaUX LucasLacerdaUX mentioned this pull request Apr 26, 2023
Open
14 tasks
@LucasLacerdaUX LucasLacerdaUX merged commit d6cf556 into main May 1, 2023
@LucasLacerdaUX LucasLacerdaUX deleted the fixed-position-background branch May 1, 2023 14:45
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
@LucasLacerdaUX
[Image Banner] Fixed background position (Shopify#2523 + Shopify#2524)
e0af80c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoboludo ludoboludo ludoboludo approved these changes

@stufreen stufreen stufreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasLacerdaUX @stufreen @ludoboludo