Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forced white text color in Image Banner & Slideshow #2663

Merged
merged 6 commits into from
May 26, 2023

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented May 19, 2023

PR Summary:

Always allow text and button color customization within the Image banner and Slideshow sections.
Important: Color scheme may need to be manually changed to prevent visual change and ensure adequate contrast.

Why are these changes introduced?

Fixes #1391

What approach did you take?

This PR does a few things:

  1. On Image Banner and Slideshow sections, it removes the forced white color for text and buttons when the content container is hidden.
  2. On Dawn's default homepage template, it changes the Image Banner's default color palette from background-1 (which uses black text) to inverse (which uses white text).
  3. It removes the "Visible when container displayed." that showed underneath the color palette control for Image Banner & Slideshow, since it's no longer relevant.

For new merchants, this approach maintains the acceptable contrast ratio that existed by default on the top of the homepage template for Dawn (the text and buttons are still white, so there's no perceptable change.)

In other areas, we cannot guarantee an acceptable ratio today anyway: If the background image is light, and/or there's no overlay applied, white text is unreadable. In the past, the merchant was stuck with that being broken. With this new approach, the merchant can fix it by applying a new color scheme.

🎥 Video
19-54-lyzp0-8gej1.mp4

Other considerations

  • This should be fine for new merchants, but if a merchant upgrades to this change automatically, they may lose their previously-white text. Is there anything we can do about that?
  • We need to double check and ensure that this works right with the starter content in our other themes that use Image Banners too.

Visual changes

If selected color scheme doesn't use white text, image banners and slideshows without content containers may have a visual change. Shops will need to manually update their color scheme to account for this.

Testing steps/scenarios

  1. Visit the demo store.
  2. Select the Image Banner at the top of the page. Change the color scheme, and note that the text + button color updates.
  3. Edit the color scheme, ensure that the new colors also appear.
  4. Repeat with a freshly-inserted Image Banner section and a Slideshow section.

Demo links

Checklist

Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just jumping on some quick feedback. Approach seems reasonable enough to me.

assets/section-image-banner.css Show resolved Hide resolved
max-width: 89rem;
border: none;
border-radius: 0;
box-shadow: none;
}

.banner--desktop-transparent .button--secondary {
--color-button: 255, 255, 255;
--color-button-text: 255, 255, 255;
--alpha-button-background: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I obviously know why this is happening, this is a weird result. Or at least it's different than the desktop equivalent. I'd expect the secondary button to stay transparent unless the mobile container was enabled https://screenshot.click/19-41-z63lp-yb7ol.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 1c9af8e, which makes this work again. I think it's fine to have the background be transparent in all cases like that, but let me know if you notice anything unexpected.

Copy link
Contributor

@eugenekasimov eugenekasimov May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, it worked for me locally, but it's not working here 😅🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled your latest changes from this PR and works on my local computer. I guess some magic is happening with connection between github and our demo store. If I go to the editor and check the code there I can see that CSS file hasn't been updated
Screenshot 2023-05-25 at 11 05 03 AM

Copy link
Contributor

@eugenekasimov eugenekasimov May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reconnected the repo and updated the link in the description to the PR. Now it looks everything working good.

Comment on lines -1198 to -1191
"color_scheme": {
"info": "Visible when container displayed."
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we go thru and remove these from all the translated files, though it technically won't hurt too much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all set in 44a0c2e. 🎉

@YoannJailin
Copy link

  • When using Image Banner and Slideshow : Go mobile and activate the "show container on mobile" option. It creates a gap between the media and the container. The container will also go under the slides counter in the case of Slideshow.

The gap will disappear once the theme is saved, but this is not a behavior we have in the current version of Dawn.

Capture d’écran, le 2023-05-19 à 14 43 56 Capture d’écran, le 2023-05-19 à 14 53 54
  • If you go mobile / show the container on mobile / play with the show container on desktop option, you will see that it impacts the background of the outline button. My guess is that this will be fixed once this fix is merged.

  • What would be the rendering for merchants that have no background activated in their image banner, once they do the update? I don't think there is a way to be sure it won't be impacted since the merchants may not have alternative color schemes with white text colors. Maybe there's a technical hack to keep them white unless they edit the scheme?

  • For our free themes : The only theme that would be impacted is Dawn. It's the only theme that use image banner/slideshow without container. I guess we should wait that the PR is merged to main then edit the color schemes for every image banner used accross the theme.

@kjellr
Copy link
Contributor Author

kjellr commented May 24, 2023

Closing in favor of #2668 for now.

@kjellr kjellr closed this May 24, 2023
@kjellr kjellr deleted the try-color-palettes-in-image-banner branch May 24, 2023 17:09
@kjellr kjellr restored the try-color-palettes-in-image-banner branch May 25, 2023 14:47
@kjellr
Copy link
Contributor Author

kjellr commented May 25, 2023

After some offline discussions, we're reopening this one. Should be ready for more dev reviews, and it needs a fix for this issue.

@kjellr kjellr reopened this May 25, 2023
@melissaperreault melissaperreault self-requested a review May 25, 2023 16:05
Copy link
Contributor

@eugenekasimov eugenekasimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that two things left to fix:

  1. Remove translations from all locales files.
  2. Address the issue when outline styled buttons on mobile inherit background colors from active container on desktop.

The rest looks good to me.

Copy link
Contributor

@eugenekasimov eugenekasimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. The only issue that I can see now is that gap between text and an image on mobile in the editor that despairs after you save. It seems that the issue came after we added animation, so it's not related to this pr. I approve 👍

Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside what was already raised for the space, LGTM! 🎉

Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just found one remaining discrepancy.

assets/section-image-banner.css Show resolved Hide resolved
@kmeleta kmeleta changed the base branch from main to release/10.0.0 May 26, 2023 16:29
@kmeleta kmeleta force-pushed the try-color-palettes-in-image-banner branch from 78dacd0 to 041a69c Compare May 26, 2023 16:38
@kmeleta kmeleta force-pushed the try-color-palettes-in-image-banner branch from 041a69c to 35ddeb6 Compare May 26, 2023 16:55
@eugenekasimov
Copy link
Contributor

It looks good to me. The only issue that I can see now is that gap between text and an image on mobile in the editor that despairs after you save. It seems that the issue came after we added animation, so it's not related to this pr. I approve 👍

I cannot replicate this issue anymore. Can some one else confirm that it's gone :) ?

@melissaperreault melissaperreault self-requested a review May 26, 2023 18:05
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kjellr kjellr merged commit 9b5839b into release/10.0.0 May 26, 2023
@kjellr kjellr deleted the try-color-palettes-in-image-banner branch May 26, 2023 19:27
ludoboludo pushed a commit that referenced this pull request Jun 5, 2023
* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.
ludoboludo added a commit that referenced this pull request Jun 6, 2023
* Fix color for image in password (#2608)

* [Image behavior] fixed background jitter fix on mobile (#2611)

* [Animation in editor] Remove transform translate when re rendering and re ordering blocks (#2614)

* Remove transform translate when re rendering and re ordering blocks

* target only what's needed

* [bug] Horizontal scrolling on mobile.  (#2617)

* Add overflow-x:hidden to prevent horizontal scrolling on mobile.

* Change margin for slider for mobile and tablet.

* Remove redundant preconnect to cdn.shopify.com (#2621)

* Update reverse scheme (#2626)

* [Footer] Remove Global Media settings inheritance from images (#2631)

* Send timezone offset as string instead of integer (#2636)

* Fix slider scrolling issue (#2635)

* Fix background gradient for Related Products. (#2641)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Quick add remove animation from image and content (#2657)

* Add default values for color scheme group (#2660)

* Revert unwanted changes (#2669)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Revert "Update from Shopify for theme dawn/release/10.0.0"

This reverts commit 89d927e.

* Remove forced white text color in Image Banner & Slideshow (#2663)

* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.

* Update existing placeholder images (#2610)

* Update existing placeholder images

* Featured collection and product card

* Featured product section

* Collection list section

* Featured blog and multirow sections

* Slideshow: change order of placeholder images

* Collage adjustments for product and collection cards

* Image with text adjustments

* Featured product: re-add `.product--no-media` selectors

* Update featured product section

* Update `card-collection`

* Cleanup `card-collection`

---------

Co-authored-by: Ludo <[email protected]>

* Gradient fix for transparent background medias and cards (#2651)

* Fix media, product, and collection cards placeholder (#2682)

* Fix missing else for collection cards (#2692)

---------

Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>
lougoncharenko pushed a commit that referenced this pull request Jun 7, 2023
* Fix color for image in password (#2608)

* [Image behavior] fixed background jitter fix on mobile (#2611)

* [Animation in editor] Remove transform translate when re rendering and re ordering blocks (#2614)

* Remove transform translate when re rendering and re ordering blocks

* target only what's needed

* [bug] Horizontal scrolling on mobile.  (#2617)

* Add overflow-x:hidden to prevent horizontal scrolling on mobile.

* Change margin for slider for mobile and tablet.

* Remove redundant preconnect to cdn.shopify.com (#2621)

* Update reverse scheme (#2626)

* [Footer] Remove Global Media settings inheritance from images (#2631)

* Send timezone offset as string instead of integer (#2636)

* Fix slider scrolling issue (#2635)

* Fix background gradient for Related Products. (#2641)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Quick add remove animation from image and content (#2657)

* Add default values for color scheme group (#2660)

* Revert unwanted changes (#2669)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Revert "Update from Shopify for theme dawn/release/10.0.0"

This reverts commit 89d927e.

* Remove forced white text color in Image Banner & Slideshow (#2663)

* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.

* Update existing placeholder images (#2610)

* Update existing placeholder images

* Featured collection and product card

* Featured product section

* Collection list section

* Featured blog and multirow sections

* Slideshow: change order of placeholder images

* Collage adjustments for product and collection cards

* Image with text adjustments

* Featured product: re-add `.product--no-media` selectors

* Update featured product section

* Update `card-collection`

* Cleanup `card-collection`

---------

Co-authored-by: Ludo <[email protected]>

* Gradient fix for transparent background medias and cards (#2651)

* Fix media, product, and collection cards placeholder (#2682)

* Fix missing else for collection cards (#2692)

---------

Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>
lougoncharenko added a commit that referenced this pull request Jun 21, 2023
* made the test/default blog post 3 by default

* blog default posts are not mobile responsive and on a slider. created snippet for blog-placeholder that renders into featured-blog with changable arguments

* removed commented out code

* default blog posts now are modifiable by post-limit and column number presets

* reformated code, reverted header back to h1, removed snippet, and made changes as suggested

* noticed the blog section needs a margin bottom when color scheme is applied

* removed padding from blog and removed date and author presets

* Fix link formatting in Related Products heading (#2680)

* fix default UI for dropdown and mega menu (#2644)

* added vertical padding and made l2 bold to mega menu

* added vertical padding to drop down

* fixed default UI for dropdown and mega menu

* added hover effect to all l2 links and fixed overlapping or mega menu

* adding padding to l3 links and fixed hover effect for dropdown

* reverted the mega menu back to the current setting

* changed horizontal grid gap on mega menu and vertical paddings on dropdown menu

* made vertical grid gap at 1.8 rem to match the 3 rem vertical paddings on mega-menu container

* removed the unnecessary lines of code

* removed the text-thickness that was making l2/l3 links a different size from l1 links

* added a hover effect over active link

* removed uneccessary link size and white space

* Add release/v10.0.0 branch fixes to main (#2693)

* Fix color for image in password (#2608)

* [Image behavior] fixed background jitter fix on mobile (#2611)

* [Animation in editor] Remove transform translate when re rendering and re ordering blocks (#2614)

* Remove transform translate when re rendering and re ordering blocks

* target only what's needed

* [bug] Horizontal scrolling on mobile.  (#2617)

* Add overflow-x:hidden to prevent horizontal scrolling on mobile.

* Change margin for slider for mobile and tablet.

* Remove redundant preconnect to cdn.shopify.com (#2621)

* Update reverse scheme (#2626)

* [Footer] Remove Global Media settings inheritance from images (#2631)

* Send timezone offset as string instead of integer (#2636)

* Fix slider scrolling issue (#2635)

* Fix background gradient for Related Products. (#2641)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Quick add remove animation from image and content (#2657)

* Add default values for color scheme group (#2660)

* Revert unwanted changes (#2669)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Revert "Update from Shopify for theme dawn/release/10.0.0"

This reverts commit 89d927e.

* Remove forced white text color in Image Banner & Slideshow (#2663)

* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.

* Update existing placeholder images (#2610)

* Update existing placeholder images

* Featured collection and product card

* Featured product section

* Collection list section

* Featured blog and multirow sections

* Slideshow: change order of placeholder images

* Collage adjustments for product and collection cards

* Image with text adjustments

* Featured product: re-add `.product--no-media` selectors

* Update featured product section

* Update `card-collection`

* Cleanup `card-collection`

---------

Co-authored-by: Ludo <[email protected]>

* Gradient fix for transparent background medias and cards (#2651)

* Fix media, product, and collection cards placeholder (#2682)

* Fix missing else for collection cards (#2692)

---------

Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>

* made the test/default blog post 3 by default

* added updated placeholder image

* added the different placeholder images, while maintaining ability to edit with presets

* blog card theme settings work on default blog posts

* removed css that wasn't being used

* reverted to original code without theme settings

* fixed prettier error by removing extra quotation mark and made test blog default instead of news

---------

Co-authored-by: Jon Neill <[email protected]>
Co-authored-by: Ludo <[email protected]>
Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>
SmolSoftBoi pushed a commit to m-k-enterprises/dawn that referenced this pull request Feb 18, 2024
)

* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* Fix color for image in password (Shopify#2608)

* [Image behavior] fixed background jitter fix on mobile (Shopify#2611)

* [Animation in editor] Remove transform translate when re rendering and re ordering blocks (Shopify#2614)

* Remove transform translate when re rendering and re ordering blocks

* target only what's needed

* [bug] Horizontal scrolling on mobile.  (Shopify#2617)

* Add overflow-x:hidden to prevent horizontal scrolling on mobile.

* Change margin for slider for mobile and tablet.

* Remove redundant preconnect to cdn.shopify.com (Shopify#2621)

* Update reverse scheme (Shopify#2626)

* [Footer] Remove Global Media settings inheritance from images (Shopify#2631)

* Send timezone offset as string instead of integer (Shopify#2636)

* Fix slider scrolling issue (Shopify#2635)

* Fix background gradient for Related Products. (Shopify#2641)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Quick add remove animation from image and content (Shopify#2657)

* Add default values for color scheme group (Shopify#2660)

* Revert unwanted changes (Shopify#2669)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Revert "Update from Shopify for theme dawn/release/10.0.0"

This reverts commit 89d927e.

* Remove forced white text color in Image Banner & Slideshow (Shopify#2663)

* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.

* Update existing placeholder images (Shopify#2610)

* Update existing placeholder images

* Featured collection and product card

* Featured product section

* Collection list section

* Featured blog and multirow sections

* Slideshow: change order of placeholder images

* Collage adjustments for product and collection cards

* Image with text adjustments

* Featured product: re-add `.product--no-media` selectors

* Update featured product section

* Update `card-collection`

* Cleanup `card-collection`

---------

Co-authored-by: Ludo <[email protected]>

* Gradient fix for transparent background medias and cards (Shopify#2651)

* Fix media, product, and collection cards placeholder (Shopify#2682)

* Fix missing else for collection cards (Shopify#2692)

---------

Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* made the test/default blog post 3 by default

* blog default posts are not mobile responsive and on a slider. created snippet for blog-placeholder that renders into featured-blog with changable arguments

* removed commented out code

* default blog posts now are modifiable by post-limit and column number presets

* reformated code, reverted header back to h1, removed snippet, and made changes as suggested

* noticed the blog section needs a margin bottom when color scheme is applied

* removed padding from blog and removed date and author presets

* Fix link formatting in Related Products heading (Shopify#2680)

* fix default UI for dropdown and mega menu (Shopify#2644)

* added vertical padding and made l2 bold to mega menu

* added vertical padding to drop down

* fixed default UI for dropdown and mega menu

* added hover effect to all l2 links and fixed overlapping or mega menu

* adding padding to l3 links and fixed hover effect for dropdown

* reverted the mega menu back to the current setting

* changed horizontal grid gap on mega menu and vertical paddings on dropdown menu

* made vertical grid gap at 1.8 rem to match the 3 rem vertical paddings on mega-menu container

* removed the unnecessary lines of code

* removed the text-thickness that was making l2/l3 links a different size from l1 links

* added a hover effect over active link

* removed uneccessary link size and white space

* Add release/v10.0.0 branch fixes to main (Shopify#2693)

* Fix color for image in password (Shopify#2608)

* [Image behavior] fixed background jitter fix on mobile (Shopify#2611)

* [Animation in editor] Remove transform translate when re rendering and re ordering blocks (Shopify#2614)

* Remove transform translate when re rendering and re ordering blocks

* target only what's needed

* [bug] Horizontal scrolling on mobile.  (Shopify#2617)

* Add overflow-x:hidden to prevent horizontal scrolling on mobile.

* Change margin for slider for mobile and tablet.

* Remove redundant preconnect to cdn.shopify.com (Shopify#2621)

* Update reverse scheme (Shopify#2626)

* [Footer] Remove Global Media settings inheritance from images (Shopify#2631)

* Send timezone offset as string instead of integer (Shopify#2636)

* Fix slider scrolling issue (Shopify#2635)

* Fix background gradient for Related Products. (Shopify#2641)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Quick add remove animation from image and content (Shopify#2657)

* Add default values for color scheme group (Shopify#2660)

* Revert unwanted changes (Shopify#2669)

* Update from Shopify for theme dawn/release/10.0.0

Committed from shop: Skeleton Theme

* Revert "Update from Shopify for theme dawn/release/10.0.0"

This reverts commit 89d927e.

* Remove forced white text color in Image Banner & Slideshow (Shopify#2663)

* Remove forced white color.

* Change color scheme for Dawn's default homepage Image Banner..

* Remove warning about color scheme usage.

* Fix bug with transparent buttons on mobile.

* Remove unused info key from translated files.

* Update display of button when it's in a mobile container.

* Update existing placeholder images (Shopify#2610)

* Update existing placeholder images

* Featured collection and product card

* Featured product section

* Collection list section

* Featured blog and multirow sections

* Slideshow: change order of placeholder images

* Collage adjustments for product and collection cards

* Image with text adjustments

* Featured product: re-add `.product--no-media` selectors

* Update featured product section

* Update `card-collection`

* Cleanup `card-collection`

---------

Co-authored-by: Ludo <[email protected]>

* Gradient fix for transparent background medias and cards (Shopify#2651)

* Fix media, product, and collection cards placeholder (Shopify#2682)

* Fix missing else for collection cards (Shopify#2692)

---------

Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>

* made the test/default blog post 3 by default

* added updated placeholder image

* added the different placeholder images, while maintaining ability to edit with presets

* blog card theme settings work on default blog posts

* removed css that wasn't being used

* reverted to original code without theme settings

* fixed prettier error by removing extra quotation mark and made test blog default instead of news

---------

Co-authored-by: Jon Neill <[email protected]>
Co-authored-by: Ludo <[email protected]>
Co-authored-by: Sofia Matulis <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Mateusz Krzeszowiak <[email protected]>
Co-authored-by: Lucas Lacerda <[email protected]>
Co-authored-by: Kjell Reigstad <[email protected]>
Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: Ken Meleta <[email protected]>
Co-authored-by: Andrew Etchen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slideshow + Image Banner when no container are limited to white text on image
5 participants